Skip to content

feat: useRate directly forR instead of max #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Apr 2, 2026
+2 −1
Merged

feat: useRate directly forR instead of max #2308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/boost/boost.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,7 +1760,8 @@ func reorderBoosters(contract *Contract) {
for _, el := range contract.Order {
elrPairs = append(elrPairs, ELRPair{
Name: el,
ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),
ELR: contract.Boosters[el].ArtifactSet.LayRate,
//ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate),
})
Comment on lines 1761 to 1765
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ContractOrderELR now sorts using ArtifactSet.LayRate, but the boost list display still shows ELR as min(LayRate, ShipRate) (see boost_draw.go). This means users may see an "ELR" value that doesn’t match the actual sort key, which can make the ordering look wrong. Consider aligning the displayed metric with the sort key (or renaming the label if the intended metric is the effective min rate). Also, please remove the commented-out previous max(...) line to avoid confusion about which metric is authoritative.

Copilot uses AI. Check for mistakes.
}

Expand Down
Loading