Conversation
There was a problem hiding this comment.
Pull request overview
Updates the contract booster ordering logic for ContractOrderELR in the boost system so that ELR ordering uses egg laying rate directly instead of combining rates via max(...).
Changes:
- Change ELR sort key from
max(LayRate, ShipRate)toLayRateinreorderBoosters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| elrPairs = append(elrPairs, ELRPair{ | ||
| Name: el, | ||
| ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate), | ||
| ELR: contract.Boosters[el].ArtifactSet.LayRate, | ||
| //ELR: max(contract.Boosters[el].ArtifactSet.LayRate, contract.Boosters[el].ArtifactSet.ShipRate), | ||
| }) |
There was a problem hiding this comment.
ContractOrderELR now sorts using ArtifactSet.LayRate, but the boost list display still shows ELR as min(LayRate, ShipRate) (see boost_draw.go). This means users may see an "ELR" value that doesn’t match the actual sort key, which can make the ordering look wrong. Consider aligning the displayed metric with the sort key (or renaming the label if the intended metric is the effective min rate). Also, please remove the commented-out previous max(...) line to avoid confusion about which metric is authoritative.
No description provided.