test: add tests for ol_openedx_auto_select_language#759
Open
test: add tests for ol_openedx_auto_select_language#759
Conversation
… view Co-authored-by: asadali145 <52656433+asadali145@users.noreply.github.com>
Co-authored-by: asadali145 <52656433+asadali145@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for ol_openedx_auto_language_select plugin
Add tests for ol_openedx_auto_select_language plugin
Mar 12, 2026
…_language tests Co-authored-by: asadali145 <52656433+asadali145@users.noreply.github.com>
Co-authored-by: asadali145 <52656433+asadali145@users.noreply.github.com>
Co-authored-by: asadali145 <52656433+asadali145@users.noreply.github.com>
Copilot
AI
changed the title
Add tests for ol_openedx_auto_select_language plugin
Reduce test duplication via parametrization and shared fixtures
Mar 12, 2026
asadali145
changed the title
Contributor
arslanashraf7
left a comment
arslanashraf7
left a comment
There was a problem hiding this comment.
a few small comments
|
|
||
|
|
||
| @pytest.fixture | ||
| def rf(): |
Contributor
There was a problem hiding this comment.
Should rename it to request_factory
Comment on lines
+19
to
+22
| @pytest.fixture | ||
| def mock_anonymous_user(mocker): | ||
| """Provide a mock anonymous user.""" | ||
| return mocker.Mock(is_authenticated=False) |
Comment on lines
+31
to
+33
| "zh_HANS", | ||
| {"zh-Hans": "chinese.srt", "en": "english.srt"}, | ||
| "zh-Hans", |
Contributor
There was a problem hiding this comment.
we should add es-419 as well, which will cover the case for code-number based language codes.
| ) | ||
|
|
||
| if expected_lang is not None: | ||
| video_child_key = next(c for c in block.children if c.block_type == "video") |
Contributor
There was a problem hiding this comment.
Maybe?
Suggested change
| video_child_key = next(c for c in block.children if c.block_type == "video") | |
| video_child = next(child for child in block.children if child.block_type == "video") |
Comment on lines
+161
to
+162
| def test_defaults_to_english_fallback(mocker, course_setup, transcripts): | ||
| """Test defaults to English for various fallback cases.""" |
Contributor
There was a problem hiding this comment.
rename ? what defaults to English fallback? dest_language?
| ) | ||
|
|
||
|
|
||
| def test_no_redirect_when_cookie_matches(rf, settings, mock_user, mocker): |
Contributor
There was a problem hiding this comment.
This and test_no_redirect_when_already_english can be combined into one parametrized test i think.
Comment on lines
+325
to
+343
| def test_resets_non_english_cookie_to_english(rf, settings, mock_user, mocker): | ||
| """Test non-English cookie reset to English.""" | ||
| settings.ENABLE_AUTO_LANGUAGE_SELECTION = True | ||
|
|
||
| mock_helpers = mocker.patch(f"{MODULE}.lang_pref_helpers") | ||
| mocker.patch(f"{MODULE}.set_user_preference") | ||
| mock_helpers.get_language_cookie.return_value = "fr" | ||
|
|
||
| middleware = CourseLanguageCookieResetMiddleware(mocker.Mock()) | ||
| request = rf.get("/some-cms-page/") | ||
| request.user = mock_user | ||
| response = HttpResponse() | ||
|
|
||
| result = middleware.process_response(request, response) | ||
|
|
||
| assert result is response | ||
| mock_helpers.set_language_cookie.assert_called_once_with( | ||
| request, response, ENGLISH_LANGUAGE_CODE | ||
| ) |
Contributor
There was a problem hiding this comment.
What is this test for? Is this in any way intended except for the authoring MFE's case? If so, we already have a test for that above.
Contributor
There was a problem hiding this comment.
This is for CourseLanguageCookieResetMiddleware, the other one is CourseLanguageCookieMiddleware when requests with Authoring MFE hit LMS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
None
Description
Add tests for ol_openedx_auto_select_language
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.