Skip to content

deps: Update vite to v8#17238

Open
kakkokari-gtyih wants to merge 23 commits intomisskey-dev:developfrom
kakkokari-gtyih:experimental-vite8
Open

deps: Update vite to v8#17238
kakkokari-gtyih wants to merge 23 commits intomisskey-dev:developfrom
kakkokari-gtyih:experimental-vite8

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 12, 2026

What

  • できそうならしょぼめのrollup pluginとかはrolldownネイティブな書き方に置き換え終わってからマージしたい
    結局ほぼ全てのrollup/viteプラグインをアップデートした
  • インライン化されたVue SFC出力に対してCSS Module定義削除が効いていなかったのを修正
  • バックエンドのCSS参照が誤っており、初期ロードで読み込まれるmain以外のCSSが読み込まれなくなっていた問題を修正
  • バックエンドのVite Manifestの保持をやめて、起動時に一度だけ必要なファイルの配列を計算してそれを保持するように

Vite v8 の簡単な測定結果は #17238 (comment)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 60.45627% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.57%. Comparing base (a3b0dc9) to head (294d66f).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/server/web/HtmlTemplateService.ts 18.69% 87 Missing ⚠️
.../lib/rollup-plugin-unwind-css-module-class-name.ts 88.51% 12 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17238      +/-   ##
===========================================
+ Coverage    63.54%   63.57%   +0.02%     
===========================================
  Files         1161     1163       +2     
  Lines       116244   116608     +364     
  Branches      8360     8446      +86     
===========================================
+ Hits         73871    74132     +261     
- Misses       40188    40287      +99     
- Partials      2185     2189       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 12, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 323.36 MB 313.00 MB -10.35 MB -3.20%
VmHWM 323.36 MB 314.59 MB -8.77 MB -2.71%
VmSize 23116.68 MB 23105.63 MB -11.04 MB -0.04%
VmData 1388.28 MB 1376.17 MB -12.11 MB -0.87%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 323.37 MB 313.10 MB -10.26 MB -3.17%
VmHWM 323.37 MB 314.59 MB -8.77 MB -2.71%
VmSize 23116.68 MB 23105.88 MB -10.79 MB -0.04%
VmData 1388.28 MB 1376.42 MB -11.86 MB -0.85%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 323.85 MB 313.58 MB -10.26 MB -3.17%
VmHWM 323.85 MB 314.81 MB -9.03 MB -2.79%
VmSize 23116.85 MB 23106.13 MB -10.71 MB -0.04%
VmData 1388.45 MB 1376.58 MB -11.86 MB -0.85%

See workflow logs for details

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

目安だいぶ早くなる

結果

  • フロントエンドビルド時間: 27s → 10s (2.7x)
  • embedフロントエンドビルド時間: 3.2s → 1.7s (1.9x)
  • 全体のビルド時間(モノレポ全体): 38s → 23s (1.7x)

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review March 19, 2026 10:49
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 19, 2026
@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

develop → 上げただけ → 調整後

  • フロントエンドビルド時間: 30.77s → 10.76s → 9.68s (3.2x)
  • embedフロントエンドビルド時間: 3.67s → 1.81s → 1.44s (2.5x)
  • 全体のビルド時間(モノレポ全体): 43s → 23s → 21s (2.0x)

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

tabun ready

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Mar 20, 2026

/preview

@kakkokari-gtyih kakkokari-gtyih changed the title deps: Update vite to v8 (wip) deps: Update vite to v8 Mar 20, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Mar 20, 2026

/preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants