Skip to content

fix(backend): 初期読込時に必要なフロントエンドのアセットがすべて読み込まれていない問題を修正#17254

Merged
syuilo merged 4 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-be-vite-assets
Mar 21, 2026
Merged

fix(backend): 初期読込時に必要なフロントエンドのアセットがすべて読み込まれていない問題を修正#17254
syuilo merged 4 commits intomisskey-dev:developfrom
kakkokari-gtyih:fix-be-vite-assets

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Mar 21, 2026

What

#17238 から抜き出した修正

  • https://ja.vite.dev/guide/backend-integration の定義に従って、必要なファイルへのリンクを全て読み込むように
  • Viteのマニフェストファイルをconfigで保持するのをやめて、必要なデータを初回に一度計算した後はHtmlTemplateServiceに保持するように

Why

場合によっては一部のCSS等が読み込まれないことがある(今のところ問題なさそうだが、 #17238 ではこの問題が発生した)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 21, 2026
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Mar 21, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 25.64103% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.52%. Comparing base (54e9426) to head (eb0beea).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ages/backend/src/server/web/HtmlTemplateService.ts 20.18% 87 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17254      +/-   ##
===========================================
- Coverage    63.56%   63.52%   -0.04%     
===========================================
  Files         1161     1161              
  Lines       116210   116300      +90     
  Branches      8356     8353       -3     
===========================================
+ Hits         73866    73881      +15     
- Misses       40140    40215      +75     
  Partials      2204     2204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 21, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 21, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.41 MB 309.95 MB -6.46 MB -2.04%
VmHWM 316.41 MB 312.21 MB -4.20 MB -1.32%
VmSize 23109.57 MB 23102.98 MB -6.58 MB -0.02%
VmData 1379.87 MB 1373.96 MB -5.91 MB -0.42%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.42 MB 309.96 MB -6.45 MB -2.03%
VmHWM 316.42 MB 312.21 MB -4.20 MB -1.32%
VmSize 23109.57 MB 23103.23 MB -6.33 MB -0.02%
VmData 1379.87 MB 1374.21 MB -5.66 MB -0.41%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 316.76 MB 310.30 MB -6.45 MB -2.03%
VmHWM 316.76 MB 312.43 MB -4.32 MB -1.36%
VmSize 23109.57 MB 23103.23 MB -6.33 MB -0.02%
VmData 1379.87 MB 1374.21 MB -5.66 MB -0.41%

See workflow logs for details

@syuilo syuilo merged commit b826a16 into misskey-dev:develop Mar 21, 2026
39 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Mar 21, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Mar 21, 2026

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-be-vite-assets branch March 21, 2026 03:45
m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Apr 12, 2026
)

* fix: バックエンドのCSS読み込みの方法が悪いのを修正

* fix: 使用されないpreloadを削除

* Update Changelog

* add comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants