Skip to content

Bumping project version and updating gitignore #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michelebastione merged 1 commit into from
Nov 16, 2025
Merged

Bumping project version and updating gitignore #901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,6 @@ FodyWeavers.xsd
*.sln.iml

/BenchmarkDotNet.Artifacts
/tests/MiniExcel.Tests.AspNetMvc/packages
/TestTemplate
/tests/MiniExcel.Tests/TemplateOptimization
/samples/xlsx/Test_EnableWriteFilePath.xlsx
/tests/MiniExcel.Core.Tests/TemplateOptimization/
/tests/data/xlsx/Test_EnableWriteFilePath.xlsx
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<TargetFrameworks>netstandard2.0;net8.0;net9.0;net10.0</TargetFrameworks>
<Version>2.0.0-preview.1</Version>
<Version>2.0.0-preview.2</Version>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<LangVersion>14</LangVersion>
Expand Down
3 changes: 2 additions & 1 deletion tests/MiniExcel.Core.Tests/MiniExcelOpenXmlConfigurationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ public class MiniExcelOpenXmlConfigurationTest
{
private readonly OpenXmlImporter _excelImporter = MiniExcel.Importers.GetOpenXmlImporter();
private readonly OpenXmlExporter _excelExporter = MiniExcel.Exporters.GetOpenXmlExporter();

[Fact]
public async Task EnableWriteFilePathTest()
public async Task DisableWriteFilePathTest()
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the new test name DisableWriteFilePathTest accurately reflects that it's testing with EnableWriteFilePath = false, the property name EnableWriteFilePath itself seems potentially misleading. The test logic suggests this property controls whether image data (byte[]) is exported, not file paths. The assertion Assert.True(rows.All(x => x.Img is null or [])) confirms that when this property is false, the image content is not written. For better code clarity and maintainability, consider renaming EnableWriteFilePath to something more descriptive like EnableImageExport or WriteImageContent in a future change. This would make the configuration option's purpose clearer to users of the library.

{
var img = await new HttpClient().GetByteArrayAsync("https://user-images.githubusercontent.com/12729184/150462383-ad9931b3-ed8d-4221-a1d6-66f799743433.png");
ImgExportTestDto[] value =
Expand Down
Loading