Skip to content

FIX: Heading tags hierarchy #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anz504 wants to merge 1 commit into from
Closed

FIX: Heading tags hierarchy #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions web/src/components/layout/Footer.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,9 @@ const FOOTER_LINKS = [
{
FOOTER_LINKS.map((section) => (
<div class='flex flex-col gap-4'>
<h3 class='text-xs font-bold tracking-[0.2em] whitespace-nowrap text-slate-900 uppercase dark:text-white'>
<span class='text-xs font-bold tracking-[0.2em] whitespace-nowrap text-slate-900 uppercase dark:text-white'>
{section.title}
</h3>
</span>
Comment on lines +127 to +129
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this element from an h3 to a span removes the semantic heading for each footer link group, which can make these sections harder to discover and navigate for screen reader users who rely on heading navigation. Consider preserving a heading element (or adding appropriate ARIA semantics) while still achieving the desired visual style, so that the footer structure remains accessible.

Copilot uses AI. Check for mistakes.
<ul class='flex flex-col gap-3'>
{section.links.map((link) => (
<li>
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/layout/Header.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ import Enlace from '@components/ui/Enlace.astro'
class='aspect-square size-7 shrink-0 sm:size-9'
iconClass='size-4 sm:size-6 animate-float-subtle'
/>
<h1
<span
class='text-2xl font-bold tracking-tight text-slate-900 sm:text-3xl dark:text-white'
>
Tailwind <span class='text-blue-500'>Animations</span>
</h1>
</span>
</div>

<button
Expand Down