Skip to content

Comments

FIX: Heading tags hierarchy#87

Open
anz504 wants to merge 1 commit intomidudev:mainfrom
anz504:fix/heading-hiearchy
Open

FIX: Heading tags hierarchy#87
anz504 wants to merge 1 commit intomidudev:mainfrom
anz504:fix/heading-hiearchy

Conversation

@anz504
Copy link

@anz504 anz504 commented Jan 25, 2026

What does this PR do?

Replace the logo h1 with a span, and change the footer heading to a span too.

Why are we doing this?

For SEO optimization and better hierarchy


Test Case(s):

Test Result(s):


Checklist

  • Tested locally
  • Added new dependencies
  • Updated the docs
  • Added a test

@vercel
Copy link

vercel bot commented Jan 25, 2026

@anz504 is attempting to deploy a commit to the midudev's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts heading usage in the shared layout to improve the page’s overall heading hierarchy for SEO and semantics, moving the primary <h1> into the main content and demoting decorative/section labels in header and footer.

Changes:

  • Replace the header logo text <h1> with a <span> so the main hero section in index.astro owns the page’s primary <h1>.
  • Replace the footer section titles’ <h3> elements with styled <span> elements to avoid additional structural headings in the footer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/src/components/layout/Header.astro Demotes the logo text from an <h1> to a non-heading <span> so the hero section’s <h1> becomes the sole primary heading.
web/src/components/layout/Footer.astro Changes footer link group titles from <h3> to <span>, keeping the same styling while removing them from the document heading outline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment on lines +127 to +129
<span class='text-xs font-bold tracking-[0.2em] whitespace-nowrap text-slate-900 uppercase dark:text-white'>
{section.title}
</h3>
</span>
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this element from an h3 to a span removes the semantic heading for each footer link group, which can make these sections harder to discover and navigate for screen reader users who rely on heading navigation. Consider preserving a heading element (or adding appropriate ARIA semantics) while still achieving the desired visual style, so that the footer structure remains accessible.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants