Skip to content

[review] [fix] Fix TRX LogFileName collision when testing multiple assemblies in a solution #16074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nohwnd wants to merge 1 commit into
base: fix/issue-15673-0ae77a4bb78cb877
Choose a base branch
from
+1 −3
Open

[review] [fix] Fix TRX LogFileName collision when testing multiple assemblies in a solution #16074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/Microsoft.TestPlatform.Acceptance.IntegrationTests/LoggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,7 @@ public void TrxLoggerShouldNotOverwriteWhenMultipleAssembliesUseSameLogFileName(
// each should get a unique file (via iteration) instead of overwriting.
SetTestEnvironment(_testEnvironment, runnerInfo);

var assembly1 = GetAssetFullPath("SimpleTestProject.dll");
var assembly2 = GetAssetFullPath("SimpleTestProject2.dll");
var assemblyPaths = $"{assembly1}\" \"{assembly2}";
var assemblyPaths = BuildMultipleAssemblyPath("SimpleTestProject.dll", "SimpleTestProject2.dll");
var trxFileName = "SharedName.trx";
var arguments = PrepareArguments(assemblyPaths, null, string.Empty, FrameworkArgValue, runnerInfo.InIsolationValue, resultsDirectory: TempDirectory.Path);
arguments = string.Concat(arguments, $" /logger:\"trx;LogFileName={trxFileName}\"");
Expand Down
Loading