[review] [fix] Fix TRX LogFileName collision when testing multiple assemblies in a solution

[nohwnd]

Caution

This PR requires manual review because threat detection produced a warning.

Reason: parse_error

Review the workflow run logs for details.

This PR contains changes that were originally intended for PR #15788 (fix/issue-15673-0ae77a4bb78cb877).
Please review the changes carefully before merging.

[nohwnd]

🧠 Expert Review — PR #16074

Scope: test/Microsoft.TestPlatform.Acceptance.IntegrationTests/LoggerTests.cs — Acceptance Test Coverage Design

Analysis

This is a focused cleanup in a single acceptance test. The change replaces a manually constructed, hand-quoted assembly path string:

// Before — fragile manual quoting
var assembly1 = GetAssetFullPath("SimpleTestProject.dll");
var assembly2 = GetAssetFullPath("SimpleTestProject2.dll");
var assemblyPaths = $"{assembly1}\" \"{assembly2}";

with the established BuildMultipleAssemblyPath helper:

// After — uses AddDoubleQuote() consistently with every other multi-assembly test
var assemblyPaths = BuildMultipleAssemblyPath("SimpleTestProject.dll", "SimpleTestProject2.dll");

Correctness: ✅ The helper (string.Join(" ", GetTestDlls(assetNames).Select(a => a.AddDoubleQuote()))) produces exactly the same format used in all other multi-assembly acceptance tests throughout the suite. The old manual approach was the outlier.

Dimension checks (Acceptance Test Coverage Design):

• ✅ No test coverage reduction — same assemblies, same test scenario
• ✅ Consistent with the established pattern across the test suite
• ✅ No concerns with cross-TFM behavior; the fix applies identically on all TFMs

Verdict: Clean refactor, no issues.

---

🧠 Reviewed by expert-reviewer · PR #16074

🧠 Reviewed by Expert Code Reviewer 🧠