Skip to content

Comments

fix: BYOK models not appearing in chat model picker#3872

Open
hoyyeva wants to merge 1 commit intomicrosoft:mainfrom
hoyyeva:hoyyeva/byok-model-picker-visibility
Open

fix: BYOK models not appearing in chat model picker#3872
hoyyeva wants to merge 1 commit intomicrosoft:mainfrom
hoyyeva:hoyyeva/byok-model-picker-visibility

Conversation

@hoyyeva
Copy link

@hoyyeva hoyyeva commented Feb 19, 2026

Summary

Ollama models are not visible in the chat model pickers with Agent mode. This is because
byokKnownModelToAPIInfo() does not set isUserSelectable: true
on the returned model metadata. VS Code's model picker filters on this field,
so all BYOK models get filtered out.

The similar function chatModelInfoToProviderMetadata() already sets
isUserSelectable: true — this is a one-line consistency fix to
byokKnownModelToAPIInfo().

Steps to reproduce

  1. Configure an Ollama provider (or any BYOK provider)
  2. Open Copilot Chat and click the model picker dropdown
  3. No BYOK models appear

Fix

Add isUserSelectable: true to the model metadata returned by
byokKnownModelToAPIInfo() in src/extension/byok/common/byokProvider.ts.

Copilot AI review requested due to automatic review settings February 19, 2026 22:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where BYOK (Bring Your Own Key) models, such as Ollama, were not appearing in the chat model picker. The root cause was that byokKnownModelToAPIInfo() was not setting isUserSelectable: true on the returned model metadata, causing VS Code's model picker to filter them out.

Changes:

  • Added isUserSelectable: true to model metadata in byokKnownModelToAPIInfo() for consistency with chatModelInfoToProviderMetadata()

@hoyyeva hoyyeva force-pushed the hoyyeva/byok-model-picker-visibility branch from ea897f8 to 03e2a32 Compare February 24, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants