fix: BYOK models not appearing in chat model picker#3872
Open
hoyyeva wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: BYOK models not appearing in chat model picker#3872hoyyeva wants to merge 1 commit intomicrosoft:mainfrom
hoyyeva wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where BYOK (Bring Your Own Key) models, such as Ollama, were not appearing in the chat model picker. The root cause was that byokKnownModelToAPIInfo() was not setting isUserSelectable: true on the returned model metadata, causing VS Code's model picker to filter them out.
Changes:
- Added
isUserSelectable: trueto model metadata inbyokKnownModelToAPIInfo()for consistency withchatModelInfoToProviderMetadata()
ea897f8 to
03e2a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ollama models are not visible in the chat model pickers with Agent mode. This is because
byokKnownModelToAPIInfo()does not setisUserSelectable: trueon the returned model metadata. VS Code's model picker filters on this field,
so all BYOK models get filtered out.
The similar function
chatModelInfoToProviderMetadata()already setsisUserSelectable: true— this is a one-line consistency fix tobyokKnownModelToAPIInfo().Steps to reproduce
Fix
Add
isUserSelectable: trueto the model metadata returned bybyokKnownModelToAPIInfo()insrc/extension/byok/common/byokProvider.ts.