Skip to content

[python] pass decompress through in iter bytes #9779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 2 commits into from
Feb 24, 2026
+10 −3
Merged

[python] pass decompress through in iter bytes #9779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35ee2be
fix stream value setting
Feb 23, 2026
7804573
add changeset
Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/python-iterBytes-2026-1-23-17-37-6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: fix
packages:
- "@typespec/http-client-python"
---

allow decompression in version tolerant
6 changes: 3 additions & 3 deletions packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ def example_template(self, builder: OperationType) -> list[str]:
def make_pipeline_call(self, builder: OperationType) -> list[str]:
retval = []
type_ignore = self.async_mode and builder.group_name == "" # is in a mixin
if builder.stream_value is True and not self.code_model.options["version-tolerant"]:
if builder.stream_value:
retval.append("_decompress = kwargs.pop('decompress', True)")
pylint_disable = " # pylint: disable=protected-access" if self.code_model.is_azure_flavor else ""
retval.extend(
Expand Down Expand Up @@ -973,7 +973,7 @@ def response_deserialization( # pylint: disable=too-many-statements
else:
stream_logic = False
if self.code_model.options["version-tolerant"]:
deserialized = "response.iter_bytes()"
deserialized = "response.iter_bytes() if _decompress else response.iter_raw()"
else:
deserialized = (
f"response.stream_download(self._client.{self.pipeline_name}, decompress=_decompress)"
Expand Down Expand Up @@ -1020,7 +1020,7 @@ def response_deserialization( # pylint: disable=too-many-statements
if len(deserialize_code) > 0:
if builder.expose_stream_keyword and stream_logic:
retval.append("if _stream:")
retval.append(" deserialized = response.iter_bytes()")
retval.append(" deserialized = response.iter_bytes() if _decompress else response.iter_raw()")
retval.append("else:")
retval.extend([f" {dc}" for dc in deserialize_code])
else:
Expand Down
Loading