Prepare for per-window settings#20328
Open
zadjii-msft wants to merge 12 commits into
Open
Conversation
…n AppLogic on startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part one of a two-part pair of PRs to add support for per window name settings to the Windows terminal.
This first PR functionally does very little. It introduces the concept of a
WindowSettingsobject, where eachWindowSettingsobject may be different based off of the name of the window. However, the settings model doesn't actually expose different instances ofWindowSettingscurrently. It just introduces one fake instance that actually just wraps the global settings object to store all of them. This means that functionally the code hasn't actually changed in this PR. We are just accessing these properties through an intermediate type.Largely this PR is mostly mechanical. where we previously would have been accessing properties on the
GlobalAppSettings, now we are just accessing the_currentWindowSettings()(via a helper, or passing as a parameter).All of this refactoring can be done now to always access the correct window settings object so that the next PR is much easier to read. That is where it will get more interesting and we will have more instances of window settings.
re: #9992