Add support for per-window-name settings#20329
Open
zadjii-msft wants to merge 11 commits into
Open
Conversation
Okay. I've made a new branch now, starting from the refactoring work we just did. Now that we've got that refactor as a base, let's take the rest of the changes from dev/migrie/fhl-spring-2026/quake-4, and apply them here. Let's actually implement the per-window-name settings, the docking settings, the _quake special casing, everything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part two of implementing per window name settings. Refer to #20328 for more context.
This PR actually does the hard work of adding multiple different window settings objects to the settings model. These are stored in the JSON as an array of window settings objects, and the name property is the key that we use in storing them internally.
One of the biggest parts of this change is the fact that the Quake window is no longer special. We can't really do that change separately from also having per window name settings. The window name
_quakeitself was special cased in so many places it did not make sense to carry that forward for a commit and then remove it in a follow-up PR.However, quake had a "docking" behavior that was not previously captured by the settings model. So, this PR adds support for that. Not only to the Quake window, but to any window that might want them.
"window.dockWindow": "none"|"top"|"left"|"right"|"bottom"- what side to dock the window to.noneis the default when omitted, but can be used to override the behavior of_quake(butwhy.gif)The window name
_quakestill defaults to top docking, FOMO. Its settings don't get persisted back to the JSON unless the user has_quakein there.Here's some JSON to play with.
Closes #9992