Update the command list when a new command is added or an existing command's name is changed#19771
Open
PankajBhojwani wants to merge 2 commits intomainfrom
Open
Update the command list when a new command is added or an existing command's name is changed#19771PankajBhojwani wants to merge 2 commits intomainfrom
PankajBhojwani wants to merge 2 commits intomainfrom
Conversation
…isting commands names are changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When a new command is added or an existing command's name is changed, make sure we update the top-level command list so that it appears there when the user navigates back to the actions page
Detailed Description of the Pull Request / Additional comments
Added a new
_CommandListDirtyflag to theActionsViewModel. When a new command is added or a command's name is changed the flag is set. When navigating to the top-level actions page, we regenerate the_CommandListif the flag is set.Validation Steps Performed
Adding a new command or updating a command's name is now reflected correctly when navigating back to the actions page.
PR Checklist