Skip to content

fix(build): avoid duplicate Content items (NETSDK1022) in targets #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgozman merged 1 commit into from
Jun 4, 2026
Merged

fix(build): avoid duplicate Content items (NETSDK1022) in targets #3320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/Playwright/build/Microsoft.Playwright.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
</PropertyGroup>
<ItemGroup Condition="'$(PlaywrightPlatform)' != 'none'">
<_PlaywrightPlatforms Include="$(PlaywrightPlatform)" />
</ItemGroup>
<!-- Per-platform node binaries, batched over %(_PlaywrightPlatforms.Identity) so that
multiple runtime identifiers each contribute their own folder. -->
<ItemGroup Condition="'$(PlaywrightPlatform)' != 'none'">
<!-- 'linux' to stay backwards compatible -->
<_PlaywrightCopyItems Include="$(MSBuildThisFileDirectory)..\.playwright\node\linux-x64\**" Condition="'%(_PlaywrightPlatforms.Identity)' == 'linux' OR '%(_PlaywrightPlatforms.Identity)' == 'linux-x64'">
<PlaywrightFolder>node\linux-x64\</PlaywrightFolder>
Expand All @@ -30,9 +34,15 @@
<_PlaywrightCopyItems Include="$(MSBuildThisFileDirectory)..\.playwright\node\win32_x64\**" Condition="'%(_PlaywrightPlatforms.Identity)' == 'win' OR '%(_PlaywrightPlatforms.Identity)' == 'win-x64'">
<PlaywrightFolder>node\win32_x64\</PlaywrightFolder>
</_PlaywrightCopyItems>
<_PlaywrightCopyItems Include="$(MSBuildThisFileDirectory)..\.playwright\node\**" Condition="'@(_PlaywrightCopyItems->Count())' == '0'">
<!-- Fallback: copy every platform's binaries when the identity is not recognized.
LICENSE is excluded here because it is added exactly once below. -->
<_PlaywrightCopyItems Include="$(MSBuildThisFileDirectory)..\.playwright\node\**" Exclude="$(MSBuildThisFileDirectory)..\.playwright\node\LICENSE" Condition="'%(_PlaywrightPlatforms.Identity)' != 'linux' AND '%(_PlaywrightPlatforms.Identity)' != 'linux-x64' AND '%(_PlaywrightPlatforms.Identity)' != 'linux-arm64' AND '%(_PlaywrightPlatforms.Identity)' != 'osx' AND '%(_PlaywrightPlatforms.Identity)' != 'osx-x64' AND '%(_PlaywrightPlatforms.Identity)' != 'osx-arm64' AND '%(_PlaywrightPlatforms.Identity)' != 'win' AND '%(_PlaywrightPlatforms.Identity)' != 'win-x64'">
<PlaywrightFolder>node\</PlaywrightFolder>
</_PlaywrightCopyItems>
</ItemGroup>
<!-- LICENSE and the JS package are platform independent. Declare them outside the batched
group above so they are added exactly once, regardless of how many platforms are listed. -->
<ItemGroup Condition="'$(PlaywrightPlatform)' != 'none'">
<_PlaywrightCopyItems Include="$(MSBuildThisFileDirectory)..\.playwright\node\LICENSE">
<PlaywrightFolder>node\</PlaywrightFolder>
</_PlaywrightCopyItems>
Expand Down
Loading