fix(build): avoid duplicate Content items (NETSDK1022) in targets#3320
Merged
Conversation
CopyPlaywrightFilesToOutput could emit the same node\LICENSE as a Content item more than once, tripping the NETSDK1022 "Duplicate Content items" check (a hard error as of .NET 10). Make the platform-specific globs and the fallback wildcard mutually exclusive via an explicit per-platform check, exclude LICENSE from the fallback wildcard, and declare the platform-independent LICENSE/package items in their own non-batched ItemGroup so they are added exactly once. Fixes microsoft#3314
pavelfeldman
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyPlaywrightFilesToOutputcould include the samenode\LICENSE(and, when the fallback ran, every node file) as aContentitem more than once, trippingNETSDK1022"Duplicate 'Content' items" — a hard error as of .NET 10.node\**wildcard are now mutually exclusive via an explicit per-platform check;LICENSEis excluded from the fallback wildcard; and the platform-independentLICENSE/packageitems are declared in their own non-batchedItemGroupso they're added exactly once.Why the old guard was fragile
The fallback wildcard was gated on
'@(_PlaywrightCopyItems->Count())' == '0', intended to copy every platform's binaries only when no platform-specific glob matched. Inside a batchedItemGroup,@(...->Count())does not reliably observe items added earlier in the same batch — in the reporter's environment it evaluated to0even after the platform glob had added items, so the fallback ran in addition to the platform-specific glob. Combined with the unconditionalnode\LICENSEinclude,node\LICENSEended up inContentmore than once. The new code drops theCount()dependency entirely.Fixes #3314