Skip to content

Fix A365 default scope to use .default suffix #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singankit wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fix A365 default scope to use .default suffix #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/microsoft/opentelemetry/a365/core/exporters/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def chunk_by_size(
return chunks


_A365_DEFAULT_SCOPE = "api://9b975845-388f-4429-889e-eab1ef63949c/Agent365.Observability.OtelWrite"
_A365_DEFAULT_SCOPE = "api://9b975845-388f-4429-889e-eab1ef63949c/.default"
Copy link
Copy Markdown
Contributor

@fpfp100 fpfp100 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why makes this change? Agent365.Observability.OtelWrite should work

Copy link
Copy Markdown
Contributor

@fpfp100 fpfp100 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Agent365.Observability.OtelWrite should work and it is the permission needed for observability. No need to have default. This is also recommended by agent team.



def _create_fic_token_resolver(scope_override: Optional[str] = None) -> Callable[[str, str], Optional[str]]:
Expand Down
Loading