Conversation
Change _A365_DEFAULT_SCOPE from api://9b975845-388f-4429-889e-eab1ef63949c/Agent365.Observability.OtelWrite to api://9b975845-388f-4429-889e-eab1ef63949c/.default Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
singankit
requested review from
JacksonWeber,
MSNev,
hectorhdzg,
jeremydvoss,
lzchen and
rads-1996
as code owners
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the default A365 OAuth scope used for token acquisition to use the .default suffix, aligning with Azure AD’s recommended pattern for application scopes.
Changes:
- Changed
_A365_DEFAULT_SCOPEfrom a specific scope (.../Agent365.Observability.OtelWrite) to the.defaultscope (.../.default).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@singankit Is there any specific reason for wanting to change the default scope? Currently we align with the export path in the upstream A365 sdk - microsoft/Agent365-python@8622478 |
When existing scope is used to get token it fails. Hence raised this PR. |
|
|
||
|
|
||
| _A365_DEFAULT_SCOPE = "api://9b975845-388f-4429-889e-eab1ef63949c/Agent365.Observability.OtelWrite" | ||
| _A365_DEFAULT_SCOPE = "api://9b975845-388f-4429-889e-eab1ef63949c/.default" |
There was a problem hiding this comment.
why makes this change? Agent365.Observability.OtelWrite should work
There was a problem hiding this comment.
/Agent365.Observability.OtelWrite should work and it is the permission needed for observability. No need to have default. This is also recommended by agent team.
Change _A365_DEFAULT_SCOPE from
api://9b975845-388f-4429-889e-eab1ef63949c/Agent365.Observability.OtelWrite to api://9b975845-388f-4429-889e-eab1ef63949c/.default