Skip to content

UefiHidDxeV2: Add keystroke repeat functionality #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
makubacki merged 3 commits into from
May 14, 2026
Merged

UefiHidDxeV2: Add keystroke repeat functionality #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42e607f
UefiHidDxeV2: Add keystroke repeat functionality
joschock Apr 29, 2026
5bf442c
UefiHidDxeV2: Hand off repeat to remaining held key on release
joschock Apr 29, 2026
cf474d9
Address review feedback.
joschock May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions HidPkg/UefiHidDxeV2/src/boot_services.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ pub trait UefiBootServices {
controller_handle: efi::Handle,
) -> efi::Status;

fn set_timer(&self, event: efi::Event, r#type: efi::TimerDelay, trigger_time: u64) -> efi::Status;

fn locate_protocol(
&self,
protocol: *mut efi::Guid,
Expand Down Expand Up @@ -195,6 +197,9 @@ impl UefiBootServices for StandardUefiBootServices {
) -> efi::Status {
(self.boot_services().locate_protocol)(protocol, registration, interface)
}
fn set_timer(&self, event: efi::Event, r#type: efi::TimerDelay, trigger_time: u64) -> efi::Status {
(self.boot_services().set_timer)(event, r#type, trigger_time)
}
}

#[cfg(test)]
Expand Down Expand Up @@ -284,6 +289,10 @@ mod test {
efi::Status::SUCCESS
}

extern "efiapi" fn mock_set_timer(_event: efi::Event, _type: efi::TimerDelay, _trigger_time: u64) -> efi::Status {
efi::Status::SUCCESS
}

#[test]
fn standard_uefi_boot_services_should_wrap_boot_services() {
let boot_services = MaybeUninit::<efi::BootServices>::zeroed();
Expand All @@ -299,6 +308,7 @@ mod test {
boot_services.open_protocol = mock_open_protocol;
boot_services.close_protocol = mock_close_protocol;
boot_services.locate_protocol = mock_locate_protocol;
boot_services.set_timer = mock_set_timer;

const TEST_GUID: efi::Guid = efi::Guid::from_fields(0, 0, 0, 0, 0, &[0, 0, 0, 0, 0, 0]);
let mut event = 1 as efi::Event;
Expand Down Expand Up @@ -373,5 +383,6 @@ mod test {
),
efi::Status::SUCCESS
);
assert_eq!(test_boot_services.set_timer(event, efi::TIMER_CANCEL, 0), efi::Status::SUCCESS);
}
}
Loading
Loading