UefiHidDxeV2: Add keystroke repeat functionality#883
Merged
makubacki merged 3 commits intoMay 14, 2026
Conversation
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/202511 #883 +/- ##
================================================
Coverage ? 2.79%
================================================
Files ? 10
Lines ? 3180
Branches ? 81
================================================
Hits ? 89
Misses ? 3091
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
May 1, 2026
makubacki
approved these changes
May 1, 2026
Contributor
Author
|
@makubacki - thanks for the comments; addressed in latest update. |
Implement keyboard repeat for held keys, matching the behavior of the legacy C HidKeyboardDxe driver: - 500ms initial delay before repeat begins - 20ms repeat rate (~50 keys/sec) while key is held - Modifier keys, toggle keys, and non-spacing (dead) keys are excluded - Last newly pressed repeatable key wins in multi-key reports - Timer cancelled on key release or keyboard reset Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When the repeating key is released while other keys are still held, select a new repeat candidate from the remaining held keys and arm the delay timer. Previously, releasing the repeat key would stop all repeat even if other repeatable keys were still pressed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joschock
force-pushed
the
personal/joschock/key_repeat
branch
from
5a76b0f to
cf474d9
Compare
Contributor
Author
|
@makubacki or @apop5 - can you take a look and provide a re-approval/merge when ready? |
makubacki
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement keyboard repeat for held keys, matching the behavior of the
legacy C HidKeyboardDxe driver:
500ms initial delay before repeat begins
20ms repeat rate (~50 keys/sec) while key is held
Modifier keys, toggle keys, and non-spacing (dead) keys are excluded
Last newly pressed repeatable key wins in multi-key reports
Timer cancelled on key release or keyboard reset
Impacts functionality?
Impacts security?
Breaking change?
Includes tests?
Includes documentation?
How This Was Tested
Included unit tests, tested on hardware at UEFI shell and confirmed expected repeat behavior.
Integration Instructions
None.