avoid SetFileCompletionNotificationModes crash#101
Open
zanderz wants to merge 1 commit intomicrosoft:mainfrom
Open
avoid SetFileCompletionNotificationModes crash#101zanderz wants to merge 1 commit intomicrosoft:mainfrom
zanderz wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
|
This was referenced Oct 30, 2018
|
any progress |
Contributor
|
Does this also replace #27, fixing #26? If I'm reading the Golang-side change, it also handles Windows XP, so I expect the answer is "yes". I'm not sure how it handles XP though. I'm also curious why the second hunk from #27 wasn't needed here, the change in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Microsoft's own documentation, there is a known bug where SetFileCompletionNotificationModes crashes on some systems (see https://support.microsoft.com/kb/2568167 for details) and a user of ours has experienced this with our software. This adapts the precautions added to Golang itself (https://go-review.googlesource.com/c/go/+/69870/).
@maxtaco