This repository was archived by the owner on Feb 12, 2019. It is now read-only.
Closed
Conversation
strib
reviewed
Oct 30, 2018
Contributor
strib
left a comment
strib
left a comment
There was a problem hiding this comment.
It seems like this commit hash isn't in github.com/keybase/go-winio. Can you commit it there first, and then vendor it in with a merged commit hash?
Contributor
Author
|
Isn't it? Just not on master? I have taken the approach of a 3rd branch, since we have 2 PRs against microsoft/go-winio |
Contributor
|
Sorry, yes I meant it's not in master. We prefer only checking in master commits here, since the branches will be deleted eventually. Is there a reason you can't merge that repo first, and then vendor here? |
Contributor
Author
|
ok @strib it vendors a hash from master. Also verified this client no longer crashes for the user with the conflicting AV installed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to include our second PR against microsoft/go-winio: microsoft/go-winio#101