Skip to content

Force common filters and group bys to be lowercase #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flanakin wants to merge 2 commits into
base: features/hubs-recs
Choose a base branch
from
+4 −4
Open

Force common filters and group bys to be lowercase #2012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
886a685
Force common filters/group bys to be lowercase
flanakin Feb 17, 2026
1e31b20
Address PR #2012 feedback
flanakin Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...mplates/finops-hub/modules/Microsoft.FinOpsHubs/Analytics/scripts/IngestionSetup_v1_2.kql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1721,8 +1721,8 @@ Recommendations_transform_v1_2()
//
| project
ProviderName,
ResourceId,
ResourceName,
ResourceId = tolower(ResourceId), // Force lowercase for consistent grouping/filtering
ResourceName = tolower(ResourceName), // Force lowercase for consistent grouping/filtering
ResourceType,
SubAccountId = coalesce(SubAccountId, iff(isnotempty(SubscriptionId), strcat('/subscriptions/', SubscriptionId), '')),
SubAccountName,
Expand All @@ -1734,8 +1734,8 @@ Recommendations_transform_v1_2()
x_RecommendationDate,
x_RecommendationDescription,
x_RecommendationDetails,
x_RecommendationId, // TODO: Set for reservation recommendations
x_ResourceGroupName,
x_RecommendationId = tolower(x_RecommendationId), // TODO: Set for reservation recommendations; force lowercase for consistent grouping/filtering
x_ResourceGroupName = tolower(x_ResourceGroupName), // Force lowercase for consistent grouping/filtering
x_SourceName,
x_SourceProvider,
x_SourceType,
Expand Down