Force common filters and group bys to be lowercase#2012
Open
flanakin wants to merge 2 commits intofeatures/hubs-recsfrom
Open
Force common filters and group bys to be lowercase#2012flanakin wants to merge 2 commits intofeatures/hubs-recsfrom
flanakin wants to merge 2 commits intofeatures/hubs-recsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the FinOps hubs ADX ingestion setup (FOCUS 1.2) to normalize casing for key recommendation columns so joins and comparisons behave consistently across datasets.
Changes:
- Lowercase
ResourceIdandResourceNameinRecommendations_transform_v1_2(). - Lowercase
x_ResourceGroupNameinRecommendations_transform_v1_2(). - Update
x_RecommendationIdprojection (now usescoalesce(...)with aResourceId-based fallback).
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Analytics/scripts/IngestionSetup_v1_2.kql
Outdated
Show resolved
Hide resolved
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Analytics/scripts/IngestionSetup_v1_2.kql
Outdated
Show resolved
Hide resolved
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Analytics/scripts/IngestionSetup_v1_2.kql
Show resolved
Hide resolved
- Remove unintended coalesce(x_RecommendationId, ResourceId) fallback - Apply tolower() directly to x_RecommendationId for consistent casing - Restore TODO comment for reservation recommendations 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
🤖 [AI][Claude] PR Update Summary Addressed: 3 thread(s)
Changes: Removed unintended |
RolandKrummenacher
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Force common filter and group-by columns to lowercase in the IngestionSetup KQL script to ensure consistent casing for joins and comparisons across datasets.
Fixes # N/A
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?