Skip to content

Comments

Force common filters and group bys to be lowercase#2012

Open
flanakin wants to merge 2 commits intofeatures/hubs-recsfrom
flanakin/hubs-recs-filters
Open

Force common filters and group bys to be lowercase#2012
flanakin wants to merge 2 commits intofeatures/hubs-recsfrom
flanakin/hubs-recs-filters

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

Force common filter and group-by columns to lowercase in the IngestionSetup KQL script to ensure consistent casing for joins and comparisons across datasets.

Fixes # N/A

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Public docs in docs-mslearn (required for dev)
  • ✅ Internal dev docs in docs-wiki (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the FinOps hubs ADX ingestion setup (FOCUS 1.2) to normalize casing for key recommendation columns so joins and comparisons behave consistently across datasets.

Changes:

  • Lowercase ResourceId and ResourceName in Recommendations_transform_v1_2().
  • Lowercase x_ResourceGroupName in Recommendations_transform_v1_2().
  • Update x_RecommendationId projection (now uses coalesce(...) with a ResourceId-based fallback).

@flanakin flanakin added this to the v14 milestone Feb 23, 2026
- Remove unintended coalesce(x_RecommendationId, ResourceId) fallback
- Apply tolower() directly to x_RecommendationId for consistent casing
- Restore TODO comment for reservation recommendations

🤖 Generated with [Claude Code](https://claude.ai/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@flanakin
Copy link
Collaborator Author

🤖 [AI][Claude] PR Update Summary

Addressed: 3 thread(s)

  • ✅ Implemented: 2
  • 💬 Not applicable: 1

Changes: Removed unintended coalesce(x_RecommendationId, ResourceId) fallback, applied tolower() directly to x_RecommendationId, and restored the original TODO comment. Changelog thread noted as not applicable since this PR targets a feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Skill: KQL KQL queries and Data Explorer integration Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants