Skip to content

Rename testing hooks for consistency and clarity #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bghgary merged 3 commits into from
Apr 10, 2026
Merged

Rename testing hooks for consistency and clarity #60

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83c75d0
Move testing hooks under test_hooks::dispatcher namespace
bghgary Apr 9, 2026
586b35e
Rename namespace to test_hooks::blocking_concurrent_queue
bghgary Apr 9, 2026
a48b83c
Rename macro ARCANA_TESTING_HOOKS to ARCANA_TEST_HOOKS
bghgary Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions Source/Shared/arcana/threading/blocking_concurrent_queue.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,27 @@
#include <utility>
#include <vector>

#ifdef ARCANA_TESTING_HOOKS
#ifdef ARCANA_TEST_HOOKS
#include <functional>
#endif

namespace arcana
{
#ifdef ARCANA_TESTING_HOOKS
namespace detail
#ifdef ARCANA_TEST_HOOKS
namespace test_hooks::blocking_concurrent_queue
{
inline std::function<void()> beforeWaitCallback{[]() {}};
}
namespace detail
{
inline std::function<void()> beforeWaitCallback{[]() {}};
}

// Set a callback to be invoked while holding the queue mutex, right before
// condition_variable::wait(). This is used for deterministic testing of
// lost-wakeup race conditions. Pass an empty lambda [](){} to reset.
inline void set_before_wait_callback(std::function<void()> callback)
{
detail::beforeWaitCallback = std::move(callback);
// Set a callback to be invoked while holding the queue mutex, right before
// condition_variable::wait(). This is used for deterministic testing of
// lost-wakeup race conditions. Pass an empty lambda [](){} to reset.
inline void set_before_wait_callback(std::function<void()> callback)
{
detail::beforeWaitCallback = std::move(callback);
}
}
#endif

Expand Down Expand Up @@ -117,8 +120,8 @@ namespace arcana
{
while (!cancel.cancelled() && m_data.empty())
{
#ifdef ARCANA_TESTING_HOOKS
detail::beforeWaitCallback();
#ifdef ARCANA_TEST_HOOKS
test_hooks::blocking_concurrent_queue::detail::beforeWaitCallback();
#endif
m_dataReady.wait(lock);
}
Expand All @@ -141,8 +144,8 @@ namespace arcana
{
while (!cancel.cancelled() && m_data.empty())
{
#ifdef ARCANA_TESTING_HOOKS
detail::beforeWaitCallback();
#ifdef ARCANA_TEST_HOOKS
test_hooks::blocking_concurrent_queue::detail::beforeWaitCallback();
#endif
m_dataReady.wait(lock);
}
Expand All @@ -164,4 +167,4 @@ namespace arcana
mutable std::mutex m_mutex;
std::condition_variable m_dataReady;
};
}
}
Loading