Rename testing hooks for consistency and clarity#60
Merged
bghgary merged 3 commits intomicrosoft:masterfrom Apr 10, 2026
Merged
Rename testing hooks for consistency and clarity#60bghgary merged 3 commits intomicrosoft:masterfrom
bghgary merged 3 commits intomicrosoft:masterfrom
Conversation
More specific namespace makes it clear these hooks are for testing the dispatcher's blocking_concurrent_queue, not general-purpose. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The hook lives in blocking_concurrent_queue, not dispatcher. Using the accurate name makes it clear where the hook fires. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Consistent with the test_hooks namespace. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bghgary
changed the title
There was a problem hiding this comment.
Pull request overview
This PR renames and relocates the blocking_concurrent_queue test hook API to improve consistency with the test_hooks naming scheme and better indicate where the hook is triggered.
Changes:
- Rename macro gate from
ARCANA_TESTING_HOOKStoARCANA_TEST_HOOKS. - Move the hook setter from the
arcana/arcana::detailarea intoarcana::test_hooks::blocking_concurrent_queue. - Update internal wait sites to invoke the callback via the new namespace path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ryantrem
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename testing hooks for consistency and clarity.
Changes
ARCANA_TESTING_HOOKStoARCANA_TEST_HOOKSto match thetest_hooksnamespacearcana::detail/arcana::set_before_wait_callbacktoarcana::test_hooks::blocking_concurrent_queuenamespace, accurately reflecting where the hook firesConsumer call changes from:
to: