[diskann-providers] Remove the LRU dependency and make vfs and serde_json optional.#733
Merged
hildebrandmw merged 1 commit intomainfrom Feb 6, 2026
Merged
[diskann-providers] Remove the LRU dependency and make vfs and serde_json optional.#733hildebrandmw merged 1 commit intomainfrom
vfs and serde_json optional.#733hildebrandmw merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR streamlines the diskann-providers crate’s dependency graph by removing an unused lru dependency (addressing an alert) and by making vfs and serde_json opt-in via crate features, reducing default build surface area.
Changes:
- Removed the unused
lrudependency fromdiskann-providers. - Made
serde_jsonoptional and enabled only via thebf_treefeature. - Made
vfsoptional and enabled only via thevirtual_storagefeature (while keeping it available for tests/benches viadev-dependencies).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
diskann-providers/Cargo.toml |
Drops lru; makes vfs/serde_json optional and wires them to virtual_storage/bf_tree features; keeps vfs in dev-deps for tests/benches. |
Cargo.toml |
Removes unused workspace dependency entries (cbindgen, csv). |
Cargo.lock |
Updates lockfile to reflect removal of lru and related transitive dependency resolution changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 428 428
Lines 78294 78294
=======================================
+ Hits 69692 69693 +1
+ Misses 8602 8601 -1 🚀 New features to boost your workflow:
|
arrayka
approved these changes
Feb 6, 2026
metajack
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the LRU crate as a dependency of
diskann-providerssince it is unused and triggering a dependabot alert. In addition, make the following dependencies optionsl:vfs- activated by the "virtual_storage" feature.serde_json- activated by the "bf_tree" feature.Finally,
cbindgenandcsvare removed from the workspace levelCargo.tomlsince they are unused.