Skip to content

Commit 354df71

Browse files
authored
[diskann-providers] Remove the LRU dependency and make vfs and serde_json optional. (#733)
Remove the LRU crate as a dependency of `diskann-providers` since it is unused and triggering a dependabot alert. In addition, make the following dependencies optionsl: * `vfs` - activated by the "virtual_storage" feature. * `serde_json` - activated by the "bf_tree" feature. Finally, `cbindgen` and `csv` are removed from the workspace level `Cargo.toml` since they are unused.
1 parent 6c3be42 commit 354df71

3 files changed

Lines changed: 6 additions & 36 deletions

File tree

Cargo.lock

Lines changed: 1 addition & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,9 @@ bincode = "1.3.3"
7272
bit-set = "0.8.0"
7373
bytemuck = "1.23.0"
7474
byteorder = "1.5.0"
75-
cbindgen = "0.28.0"
7675
cfg-if = "1.0.0"
7776
clap = "4.5.45"
7877
criterion = "0.5.1"
79-
csv = "1.3.1"
8078
dashmap = "6.1.0"
8179
futures-util = { version = "0.3.31", default-features = false }
8280
half = "2.6.0"

diskann-providers/Cargo.toml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ half = { workspace = true, features = ["bytemuck", "num-traits"] }
1818
hashbrown.workspace = true
1919
num-traits.workspace = true
2020
once_cell.workspace = true
21-
lru = "0.12.3"
2221
rand.workspace = true
2322
rayon.workspace = true
2423
serde = { workspace = true, features = ["derive"] }
@@ -32,7 +31,6 @@ diskann-wide = { workspace = true }
3231
arc-swap.workspace = true
3332
tracing.workspace = true
3433
diskann-linalg = { workspace = true }
35-
vfs = { workspace = true }
3634
diskann = { workspace = true }
3735
diskann-utils = { workspace = true }
3836
diskann-quantization = { workspace = true, features = ["rayon"] }
@@ -43,7 +41,8 @@ anyhow.workspace = true
4341
prost = "0.14.1"
4442
futures-util.workspace = true
4543
polonius-the-crab = { version = "0.5.0", optional = true }
46-
serde_json.workspace = true
44+
serde_json = { workspace = true, optional = true }
45+
vfs = { workspace = true, optional = true }
4746

4847
[dev-dependencies]
4948
approx.workspace = true
@@ -52,9 +51,9 @@ iai-callgrind.workspace = true
5251
itertools.workspace = true
5352
tempfile.workspace = true
5453
rstest.workspace = true
55-
serde_json.workspace = true
5654
tokio = { workspace = true, features = ["full"] }
5755
proptest.workspace = true
56+
vfs.workspace = true
5857

5958
[[bench]]
6059
name = "bench_main"
@@ -79,9 +78,9 @@ targets = [
7978
default = []
8079
perf_test = ["dep:opentelemetry"]
8180
testing = ["dep:tempfile"]
82-
bf_tree = ["dep:bf-tree", "dep:polonius-the-crab"]
81+
bf_tree = ["dep:bf-tree", "dep:polonius-the-crab", "dep:serde_json"]
8382
experimental_diversity_search = ["diskann/experimental_diversity_search"]
84-
virtual_storage = []
83+
virtual_storage = ["dep:vfs"]
8584

8685
# Some 'cfg's in the source tree will be flagged by `cargo clippy -j 2 --workspace --no-deps --all-targets -- -D warnings`
8786
[lints.rust]

0 commit comments

Comments
 (0)