-
Notifications
You must be signed in to change notification settings - Fork 24
fix dependency on agent-framework sample app #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,17 +7,20 @@ authors = [ | |
| ] | ||
| dependencies = [ | ||
| # AgentFramework SDK - The official package | ||
| "agent-framework-azure-ai", | ||
| "agent-framework-azure-ai==1.0.0b251114", | ||
| "agent-framework-core==1.0.0b251114", | ||
|
|
||
| # Azure AI Projects - explicitly require pre-release version | ||
| "azure-ai-agents>=1.2.0b5", | ||
| "azure-ai-projects>=2.0.0b2", | ||
|
|
||
| # Microsoft Agents SDK - Official packages for hosting and integration | ||
| "microsoft-agents-hosting-aiohttp", | ||
| "microsoft-agents-hosting-core", | ||
| "microsoft-agents-hosting-core>= 0.4.0", | ||
| "microsoft-agents-authentication-msal", | ||
| "microsoft-agents-activity", | ||
| "microsoft-agents-activity>= 0.4.0", | ||
|
Comment on lines
18
to
+21
|
||
|
|
||
| "opentelemetry-semantic-conventions-ai==0.4.13", | ||
|
|
||
| # Azure SDK components | ||
| "azure-identity", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description mentions pinning to versions defined in a constraints file, but this sample project doesn’t include or reference any constraints/lock file (and the only change here is direct pinning in
dependencies). Consider either adding a repo-local constraints/lock mechanism (e.g.,uv.lockor documented constraints usage) or updating the PR description to match the actual approach.