Skip to content

fix dependency on agent-framework sample app#229

Open
nikhilNava wants to merge 1 commit intomainfrom
nikhilc/fixDependency
Open

fix dependency on agent-framework sample app#229
nikhilNava wants to merge 1 commit intomainfrom
nikhilc/fixDependency

Conversation

@nikhilNava
Copy link

Issue
The sample apps does not use fixed dependencies.

Solution
Pin the dependencies to the version defined in constraints file

https://github.com/[microsoft/Agent365-python](https://github.com/microsoft/Agent365-python/blob/main/pyproject.toml#L68)/blob/main/pyproject.toml#L68

This specific issue also occurred because agent-framework has a hard dependency on semantic conventions. The agent365 SDK should consider pinning the semantic convention version when using agent-framework like in agent-framework tooling extention

Copilot AI review requested due to automatic review settings February 27, 2026 15:02
@nikhilNava nikhilNava requested a review from a team as a code owner February 27, 2026 15:02
@github-actions
Copy link

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins key Agent Framework dependencies in the Python Agent Framework sample to avoid breakages caused by upstream dependency changes (notably around OpenTelemetry semantic conventions).

Changes:

  • Pin agent-framework-azure-ai and add/pin agent-framework-core to a specific pre-release build.
  • Add an explicit pin for opentelemetry-semantic-conventions-ai.
  • Add minimum versions for some microsoft-agents-* dependencies.
Comments suppressed due to low confidence (1)

python/agent-framework/sample-agent/pyproject.toml:15

  • This file still allows dependency drift (e.g., azure-ai-agents>=... / azure-ai-projects>=...). If the goal is fully reproducible installs for the sample, pin these direct dependencies too (or introduce a lock/constraints workflow) so users don’t pick up breaking pre-release updates unexpectedly.
    # Azure AI Projects - explicitly require pre-release version
    "azure-ai-agents>=1.2.0b5",
    "azure-ai-projects>=2.0.0b2",

Comment on lines 18 to +21
"microsoft-agents-hosting-aiohttp",
"microsoft-agents-hosting-core",
"microsoft-agents-hosting-core>= 0.4.0",
"microsoft-agents-authentication-msal",
"microsoft-agents-activity",
"microsoft-agents-activity>= 0.4.0",
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some microsoft-agents-* packages have version constraints now (hosting-core, activity), while hosting-aiohttp and authentication-msal are unbounded. To reduce the chance of pulling incompatible combinations, apply a consistent pin/range strategy across the whole microsoft-agents-* set (ideally keeping them on the same version).

Copilot uses AI. Check for mistakes.
Comment on lines +10 to 12
"agent-framework-azure-ai==1.0.0b251114",
"agent-framework-core==1.0.0b251114",

Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions pinning to versions defined in a constraints file, but this sample project doesn’t include or reference any constraints/lock file (and the only change here is direct pinning in dependencies). Consider either adding a repo-local constraints/lock mechanism (e.g., uv.lock or documented constraints usage) or updating the PR description to match the actual approach.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants