Skip to content

Fix loading bar not resetting on network errors #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richard-to wants to merge 2 commits into from
Closed

Fix loading bar not resetting on network errors #1322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23b781b
Fix loading bar not resetting on network errors
claude Dec 16, 2025
5196d42
Ensure connection re-establishes after network errors
claude Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions mesop/web/src/services/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,30 @@ export class Channel {
this.queueMessage(request, uiResponse);
});
});

this.eventSource.addEventListener('error', (e) => {
zone.run(async () => {
console.error('SSE error:', e);
this.status = ChannelStatus.CLOSED;
clearTimeout(this.isWaitingTimeout);
this.isWaiting = false;
this._isHotReloading = false;
await this.processMessageQueue();
this.dequeueEvent();
});
});

this.eventSource.addEventListener('abort', (e) => {
zone.run(async () => {
console.error('SSE aborted:', e);
this.status = ChannelStatus.CLOSED;
clearTimeout(this.isWaitingTimeout);
this.isWaiting = false;
this._isHotReloading = false;
await this.processMessageQueue();
this.dequeueEvent();
});
});
}

private initWebSocket(initParams: InitParams, request: UiRequest) {
Expand Down Expand Up @@ -217,16 +241,26 @@ export class Channel {
};

this.webSocket.onerror = (error) => {
zone.run(() => {
zone.run(async () => {
console.error('WebSocket error:', error);
this.status = ChannelStatus.CLOSED;
clearTimeout(this.isWaitingTimeout);
this.isWaiting = false;
this._isHotReloading = false;
await this.processMessageQueue();
this.dequeueEvent();
});
};

this.webSocket.onclose = (event) => {
zone.run(() => {
zone.run(async () => {
console.error('WebSocket closed:', event.reason);
this.status = ChannelStatus.CLOSED;
clearTimeout(this.isWaitingTimeout);
this.isWaiting = false;
this._isHotReloading = false;
await this.processMessageQueue();
this.dequeueEvent();

// Attempt to reconnect if we haven't exceeded max attempts
if (this.wsReconnectAttempts < this.wsMaxReconnectAttempts) {
Expand Down
Loading