Fix loading bar not resetting on network errors#1322
Closed
richard-to wants to merge 2 commits intomainfrom
Closed
Fix loading bar not resetting on network errors#1322richard-to wants to merge 2 commits intomainfrom
richard-to wants to merge 2 commits intomainfrom
Conversation
When Chrome encounters ERR_NETWORK_CHANGED or other network errors, the SSE/WebSocket connection is terminated abnormally without sending a STREAM_END signal. This caused the loading bar to remain visible indefinitely because the isWaiting flag and timeout were never cleared. This fix adds proper error handling: - For SSE: Added 'error' and 'abort' event listeners - For WebSocket: Updated 'onerror' and 'onclose' handlers Both now properly clear the isWaitingTimeout and reset the isWaiting and _isHotReloading flags to ensure the loading bar hides correctly. Fixes #1312
After a network error, the UI was not responding to events because: 1. SSE error handlers weren't setting status to CLOSED, so events got queued instead of re-initializing the connection 2. Error handlers weren't calling dequeueEvent() to process queued events Now all error handlers (SSE error/abort, WebSocket error/close): - Set status to CLOSED so dispatch() knows to re-initialize - Process message queue to handle any pending responses - Dequeue events to ensure pending user interactions are processed This allows the connection to properly re-establish when the user interacts after network connectivity is restored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Chrome encounters ERR_NETWORK_CHANGED or other network errors,
the SSE/WebSocket connection is terminated abnormally without sending
a STREAM_END signal. This caused the loading bar to remain visible
indefinitely because the isWaiting flag and timeout were never cleared.
This fix adds proper error handling:
Both now properly clear the isWaitingTimeout and reset the isWaiting
and _isHotReloading flags to ensure the loading bar hides correctly.
Fixes #1312