adapting changes in NRP to the master branch #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion as maximisation objective again, added testcase
alxbrd
reviewed
Apr 21, 2020
| println("Found satisfaction: " + satisfaction) | ||
|
|
||
| return -1 * satisfaction; | ||
| return satisfaction; |
Member
There was a problem hiding this comment.
This is a minimisation problem (-1 > 1 in objective space)
Contributor
Author
There was a problem hiding this comment.
Sorry, that tendency stuff confused me again. For some reason I still thought the specified tendency will take care of the negation, now.
In fact it does for OCL guidance functions, right? Were there any drawbacks in doing the same thing for Java guidance functions?
…em (as expected by moea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Alex, I just realized that my fixes on NRP branch were not adapted to changes on the upstream repository. You changed the structure and integrated the use cases in master. So I thought, it should be helpful to integrate the NRP fixes.
I don't know if there is a specific reason for it but you changed satisfaction to be a minimization objective. However, you did not update the mopt files accordingly. I switched back to a maximization objective in order to stay coherent and to be able to un-comment the test cases again without adapting all their asserts.
If you need it to be a minimization objective, I will be happy to adapt everything accordingly. Just tell me.