add DeprecationWarning to geneset() and snp_dataset() #1274
Open
ZiadXI wants to merge 1 commit intomalariagen:masterfrom
Open
add DeprecationWarning to geneset() and snp_dataset() #1274ZiadXI wants to merge 1 commit intomalariagen:masterfrom
ZiadXI wants to merge 1 commit intomalariagen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #1273
Both methods have been renamed for a while now, but calls were being forwarded without notifying users. I noticed while going through the codebase that there's no warning at all, unlike
cnv_discordant_read_calls(), which already does this correctly.This adds a DeprecationWarning to both, pointing users to the new names:
geneset()->genome_features()snp_dataset()->snp_calls()No behavior changes, just makes the deprecation actually visible.