Skip to content

Fix lrelease path and add a missing include header #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hillwoodroc wants to merge 2 commits into
base: develop/snipe
Choose a base branch
from
Open

Fix lrelease path and add a missing include header #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0a5fff
chore: translate_generation.sh: detect lrelease path dynamically
hillwoodroc May 28, 2025
cbe7e4c
fix: vnotea2tmanager: add missing include for QJsonDocument
hillwoodroc May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion assets/translate_generation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,19 @@ fi

ts_list=(`ls ${translations_dir}/*.ts`)

if [ -f "/usr/bin/lrelease6" ]; then
LRELEASE=lrelease6
elif [ -f "/usr/lib/qt6/bin/lrelease" ]; then
LRELEASE=/usr/lib/qt6/bin/lrelease
elif [ -f "/usr/lib64/qt6/bin/lrelease" ]; then
RELEASE=/usr/lib64/qt6/bin/lrelease
Copy link
Copy Markdown
Member

@BLumia BLumia Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RELEASE=/usr/lib64/qt6/bin/lrelease
LRELEASE=/usr/lib64/qt6/bin/lrelease

else
echo "lrelease: command not found."
exit 1
fi

for ts in "${ts_list[@]}"
do
printf "\nprocess ${ts}\n"
/usr/lib/qt6/bin/lrelease "${ts}"
${LRELEASE} "${ts}"
done
1 change: 1 addition & 0 deletions src/common/vnotea2tmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,12 @@

#include <DSysInfo>

#include <QDBusInterface>

Check warning on line 10 in src/common/vnotea2tmanager.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QDBusInterface> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QDBusError>

Check warning on line 11 in src/common/vnotea2tmanager.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QDBusError> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QJsonParseError>

Check warning on line 12 in src/common/vnotea2tmanager.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QJsonParseError> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QJsonDocument>

Check warning on line 13 in src/common/vnotea2tmanager.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QJsonDocument> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include <QTimer>

Check warning on line 15 in src/common/vnotea2tmanager.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QTimer> not found. Please note: Cppcheck does not need standard library headers to get proper results.

DCORE_USE_NAMESPACE

Expand Down