Skip to content

Fix lrelease path and add a missing include header#219

Open
hillwoodroc wants to merge 2 commits into
linuxdeepin:develop/snipefrom
hillwoodroc:develop/snipe
Open

Fix lrelease path and add a missing include header#219
hillwoodroc wants to merge 2 commits into
linuxdeepin:develop/snipefrom
hillwoodroc:develop/snipe

Conversation

@hillwoodroc
Copy link
Copy Markdown

@hillwoodroc hillwoodroc commented May 28, 2025

No description provided.

@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented May 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented May 28, 2025

Hi @hillwoodroc. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Copy Markdown

deepin-ci-robot commented May 28, 2025

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hillwoodroc
chore: translate_generation.sh: detect lrelease path dynamically
b0a5fff 
Improve compatibility by detecting available lrelease executable
dynamically instead of hardcoding the Qt6 path.

The script now checks for lrelease6, /usr/lib/qt6/bin/lrelease, and
/usr/lib64/qt6/bin/lrelease. If none are found, it prints an error
message and exits with code 1.

This allows the script to work across distributions where Qt6 may be
installed in different locations.

Log: Fixes potential failure in translation generation on systems without
a fixed lrelease path.
@hillwoodroc
fix: vnotea2tmanager: add missing include for QJsonDocument
cbe7e4c 
This patch adds `#include <QJsonDocument>` to ensure the class is fully
defined, allowing proper use of `QJsonDocument::fromJson(...)` in
asrJsonParser().

This resolves a build failure with some compilers or environments where
the implicit inclusion of QJsonDocument does not occur.

Log: Fix build error caused by missing QJsonDocument definition:
"error: variable ‘QJsonDocument doc’ has initializer but incomplete type"
@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 30, 2025

TAG Bot

New tag: 6.5.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #220

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 5, 2025

TAG Bot

New tag: 6.5.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #221

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 13, 2025

TAG Bot

New tag: 6.5.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #224

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 19, 2025

TAG Bot

New tag: 6.5.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #226

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 20, 2025

TAG Bot

New tag: 6.5.26
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #228

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 20, 2025

TAG Bot

New tag: 6.5.27
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #229

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 21, 2025

TAG Bot

New tag: 6.5.28
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #230

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 21, 2025

TAG Bot

New tag: 6.5.29
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #231

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 23, 2025

TAG Bot

New tag: 6.5.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #234

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 24, 2025

TAG Bot

New tag: 6.5.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #235

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 26, 2025

TAG Bot

New tag: 6.5.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #236

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 27, 2025

TAG Bot

New tag: 6.5.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #237

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 10, 2025

TAG Bot

New tag: 6.5.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #240

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 17, 2025

TAG Bot

New tag: 6.5.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #245

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jul 31, 2025

TAG Bot

New tag: 6.5.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #257

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 7, 2025

TAG Bot

New tag: 6.5.37
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #263

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 13, 2025

TAG Bot

New tag: 6.5.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #269

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 21, 2025

TAG Bot

New tag: 6.5.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #273

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Aug 28, 2025

TAG Bot

New tag: 6.5.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #276

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Sep 17, 2025

TAG Bot

New tag: 6.5.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #278

BLumia
BLumia requested changes Sep 18, 2025
View reviewed changes
Comment thread assets/translate_generation.sh
elif [ -f "/usr/lib/qt6/bin/lrelease" ]; then
LRELEASE=/usr/lib/qt6/bin/lrelease
elif [ -f "/usr/lib64/qt6/bin/lrelease" ]; then
RELEASE=/usr/lib64/qt6/bin/lrelease
Copy link
Copy Markdown
Member

@BLumia BLumia Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RELEASE=/usr/lib64/qt6/bin/lrelease
LRELEASE=/usr/lib64/qt6/bin/lrelease

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Sep 25, 2025

TAG Bot

New tag: 6.5.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #281

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 10, 2025

TAG Bot

New tag: 6.5.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #282

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 10, 2025

TAG Bot

New tag: 6.5.44
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #283

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 16, 2025

TAG Bot

New tag: 6.5.45
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #291

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 23, 2025

TAG Bot

New tag: 6.5.46
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #295

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Oct 30, 2025

TAG Bot

New tag: 6.5.47
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #306

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 6, 2025

TAG Bot

New tag: 6.5.48
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #308

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 13, 2025

TAG Bot

New tag: 6.5.49
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #310

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 20, 2025

TAG Bot

New tag: 6.5.50
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #317

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Nov 27, 2025

TAG Bot

New tag: 6.5.51
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #319

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 6, 2026

TAG Bot

New tag: 6.5.53
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #329

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jan 22, 2026

TAG Bot

New tag: 6.5.54
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #333

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Feb 5, 2026

TAG Bot

New tag: 6.5.55
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #338

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Mar 5, 2026

TAG Bot

New tag: 6.5.56
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #341

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented May 19, 2026

TAG Bot

New tag: 6.5.57
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BLumia BLumia BLumia requested changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hillwoodroc @deepin-ci-robot @BLumia