Skip to content

[Merged by Bors] - feat(Analysis/Hermitian): more lemma to convert between IsHermitian and IsSymmetric#37394

Closed
wwylele wants to merge 7 commits intoleanprover-community:masterfrom
wwylele:prod-eigen-2
Closed

[Merged by Bors] - feat(Analysis/Hermitian): more lemma to convert between IsHermitian and IsSymmetric#37394
wwylele wants to merge 7 commits intoleanprover-community:masterfrom
wwylele:prod-eigen-2

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Mar 30, 2026

Separated from #37325


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

PR summary 1a37cd3c8e

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Analysis.Matrix.Hermitian 2132 2145 +13 (+0.61%)
Import changes for all files
Files Import difference
Mathlib.Analysis.Matrix.Hermitian 13

Declarations diff

+ LinearMap.isHermitian_toMatrix_iff
+ isSymmetric_toEuclideanLin_iff
+ isSymmetric_toLin_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Mar 30, 2026
wwylele and others added 2 commits March 31, 2026 07:40
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Co-authored-by: Monica Omar <23701951+themathqueen@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 31, 2026

✌️ wwylele can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 31, 2026
wwylele and others added 3 commits March 31, 2026 19:06
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Mar 31, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 31, 2026
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 31, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/Hermitian): more lemma to convert between IsHermitian and IsSymmetric [Merged by Bors] - feat(Analysis/Hermitian): more lemma to convert between IsHermitian and IsSymmetric Mar 31, 2026
@mathlib-bors mathlib-bors bot closed this Mar 31, 2026
@wwylele wwylele deleted the prod-eigen-2 branch March 31, 2026 23:56
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants