[Merged by Bors] - feat(Analysis/InnerProductSpace): transfer lemmas about charpoly/eigenvalues from matrix to linear map#37325
Closed
wwylele wants to merge 9 commits intoleanprover-community:masterfrom
Closed
Conversation
…nvalues from matrix to linear map
PR summary be85740951Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.LinearAlgebra.Eigenspace.Charpoly | 1684 | 1743 | +59 (+3.50%) |
| Mathlib.Analysis.InnerProductSpace.Spectrum | 2360 | 2369 | +9 (+0.38%) |
| Mathlib.Analysis.InnerProductSpace.Trace | 2365 | 2370 | +5 (+0.21%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Analysis.InnerProductSpace.SingularValues |
2 |
9 filesMathlib.Analysis.InnerProductSpace.Positive Mathlib.Analysis.InnerProductSpace.Reproducing Mathlib.Analysis.InnerProductSpace.StarOrder Mathlib.Analysis.Normed.Operator.ContinuousAlgEquiv Mathlib.Probability.Distributions.Gaussian.CharFun Mathlib.Probability.Distributions.Gaussian.HasGaussianLaw.Independence Mathlib.Probability.Distributions.Gaussian.IsGaussianProcess.Independence Mathlib.Probability.Distributions.Gaussian.Multivariate Mathlib.Probability.Moments.CovarianceBilin |
4 |
Mathlib.Analysis.InnerProductSpace.Trace |
5 |
6 filesMathlib.Analysis.Matrix.HermitianFunctionalCalculus Mathlib.Analysis.Matrix.LDL Mathlib.Analysis.Matrix.Order Mathlib.Analysis.Matrix.PosDef Mathlib.Analysis.Matrix.Spectrum Mathlib.Combinatorics.SimpleGraph.LapMatrix |
8 |
Mathlib.Analysis.InnerProductSpace.JointEigenspace Mathlib.Analysis.InnerProductSpace.Spectrum |
9 |
Mathlib.LinearAlgebra.Eigenspace.Charpoly |
59 |
Declarations diff
+ charpoly_eq
+ det_eq_prod_eigenvalues
+ det_eq_prod_roots_charpoly_of_splits
+ eigenvalues_eq_eigenvalues_iff
+ roots_charpoly_eq_eigenvalues
+ sort_roots_charpoly_eq_eigenvalues
+ splits_charpoly
+ toMatrix_eigenvectorBasis
+ trace_eq_sum_roots_charpoly_of_splits
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Collaborator
Author
|
t-analysis |
Collaborator
themathqueen
left a comment
There was a problem hiding this comment.
LGTM except this tiny comment, let's see what Jireh thinks about it.
(apparently, both your PR and the matrix version #29476 used the Aristotle-Harmonic bot 👀)
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
…nvalues from matrix to linear map (#37325) These are some lemmas existing for matrix but missing for linear map. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
aditya-ramabadran
pushed a commit
to aditya-ramabadran/mathlib4
that referenced
this pull request
Apr 1, 2026
…nvalues from matrix to linear map (leanprover-community#37325) These are some lemmas existing for matrix but missing for linear map. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
aditya-ramabadran
pushed a commit
to aditya-ramabadran/mathlib4
that referenced
this pull request
Apr 1, 2026
…nd IsSymmetric (leanprover-community#37394) Separated from leanprover-community#37325
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 3, 2026
…nvalues from matrix to linear map (leanprover-community#37325) These are some lemmas existing for matrix but missing for linear map. Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
xroblot
pushed a commit
to xroblot/mathlib4
that referenced
this pull request
Apr 3, 2026
…nd IsSymmetric (leanprover-community#37394) Separated from leanprover-community#37325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some lemmas existing for matrix but missing for linear map.
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun
AI usage disclosure: I used Aristotle initially to one-shot the missing lemma
LinearMap.det_eq_prod_eigenvalues, and then worked manually to break them into small pieces and align them with existing lemmas.Here is a list of correspondence between new lemma and existing ones. Some of these have names and statements that I wouldn't be sure about if I had come up on my own, so I used the existing ones as justification for how they are named / stated