Skip to content

[Merged by Bors] - feat(Analysis/InnerProductSpace): transfer lemmas about charpoly/eigenvalues from matrix to linear map#37325

Closed
wwylele wants to merge 9 commits intoleanprover-community:masterfrom
wwylele:prod-eigen
Closed

[Merged by Bors] - feat(Analysis/InnerProductSpace): transfer lemmas about charpoly/eigenvalues from matrix to linear map#37325
wwylele wants to merge 9 commits intoleanprover-community:masterfrom
wwylele:prod-eigen

Conversation

@wwylele
Copy link
Copy Markdown
Collaborator

@wwylele wwylele commented Mar 29, 2026

These are some lemmas existing for matrix but missing for linear map.

Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun


AI usage disclosure: I used Aristotle initially to one-shot the missing lemma LinearMap.det_eq_prod_eigenvalues, and then worked manually to break them into small pieces and align them with existing lemmas.

Here is a list of correspondence between new lemma and existing ones. Some of these have names and statements that I wouldn't be sure about if I had come up on my own, so I used the existing ones as justification for how they are named / stated

Open in Gitpod

@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Mar 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

PR summary be85740951

Import changes exceeding 2%

% File
+3.50% Mathlib.LinearAlgebra.Eigenspace.Charpoly

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.LinearAlgebra.Eigenspace.Charpoly 1684 1743 +59 (+3.50%)
Mathlib.Analysis.InnerProductSpace.Spectrum 2360 2369 +9 (+0.38%)
Mathlib.Analysis.InnerProductSpace.Trace 2365 2370 +5 (+0.21%)
Import changes for all files
Files Import difference
Mathlib.Analysis.InnerProductSpace.SingularValues 2
9 files Mathlib.Analysis.InnerProductSpace.Positive Mathlib.Analysis.InnerProductSpace.Reproducing Mathlib.Analysis.InnerProductSpace.StarOrder Mathlib.Analysis.Normed.Operator.ContinuousAlgEquiv Mathlib.Probability.Distributions.Gaussian.CharFun Mathlib.Probability.Distributions.Gaussian.HasGaussianLaw.Independence Mathlib.Probability.Distributions.Gaussian.IsGaussianProcess.Independence Mathlib.Probability.Distributions.Gaussian.Multivariate Mathlib.Probability.Moments.CovarianceBilin
4
Mathlib.Analysis.InnerProductSpace.Trace 5
6 files Mathlib.Analysis.Matrix.HermitianFunctionalCalculus Mathlib.Analysis.Matrix.LDL Mathlib.Analysis.Matrix.Order Mathlib.Analysis.Matrix.PosDef Mathlib.Analysis.Matrix.Spectrum Mathlib.Combinatorics.SimpleGraph.LapMatrix
8
Mathlib.Analysis.InnerProductSpace.JointEigenspace Mathlib.Analysis.InnerProductSpace.Spectrum 9
Mathlib.LinearAlgebra.Eigenspace.Charpoly 59

Declarations diff

+ charpoly_eq
+ det_eq_prod_eigenvalues
+ det_eq_prod_roots_charpoly_of_splits
+ eigenvalues_eq_eigenvalues_iff
+ roots_charpoly_eq_eigenvalues
+ sort_roots_charpoly_eq_eigenvalues
+ splits_charpoly
+ toMatrix_eigenvectorBasis
+ trace_eq_sum_roots_charpoly_of_splits

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@wwylele
Copy link
Copy Markdown
Collaborator Author

wwylele commented Mar 29, 2026

t-analysis

@github-actions github-actions bot added the t-analysis Analysis (normed *, calculus) label Mar 29, 2026
@wwylele wwylele requested a review from themathqueen March 30, 2026 21:22
Copy link
Copy Markdown
Collaborator

@themathqueen themathqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except this tiny comment, let's see what Jireh thinks about it.

(apparently, both your PR and the matrix version #29476 used the Aristotle-Harmonic bot 👀)

Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 31, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 31, 2026
…nvalues from matrix to linear map (#37325)

These are some lemmas existing for matrix but missing for linear map.

Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 31, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Analysis/InnerProductSpace): transfer lemmas about charpoly/eigenvalues from matrix to linear map [Merged by Bors] - feat(Analysis/InnerProductSpace): transfer lemmas about charpoly/eigenvalues from matrix to linear map Mar 31, 2026
@mathlib-bors mathlib-bors bot closed this Mar 31, 2026
@wwylele wwylele deleted the prod-eigen branch March 31, 2026 22:27
mathlib-bors bot pushed a commit that referenced this pull request Mar 31, 2026
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
…nvalues from matrix to linear map (leanprover-community#37325)

These are some lemmas existing for matrix but missing for linear map.

Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
aditya-ramabadran pushed a commit to aditya-ramabadran/mathlib4 that referenced this pull request Apr 1, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
…nvalues from matrix to linear map (leanprover-community#37325)

These are some lemmas existing for matrix but missing for linear map.

Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun>
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants