test: uniformize VM test helper naming and boolean assertions

SysManager/SysManager.Tests/BulkInstallerViewModelTests.cs

@@ -14,35 +14,35 @@ namespace SysManager.Tests;
 /// </summary>
 public class BulkInstallerViewModelTests
 {
-    private static BulkInstallerViewModel CreateVm() =>
+    private static BulkInstallerViewModel NewVm() =>
         new(new BulkInstallerService(new PowerShellRunner()), new AppIconService());
 
     [Fact]
     public void Constructor_PopulatesAppsWithCuratedList()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(46, vm.Apps.Count);
     }
 
     [Fact]
     public void Constructor_FilteredAppsMatchesAllApps()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(vm.Apps.Count, vm.FilteredApps.Count);
     }
 
     [Fact]
     public void SelectAll_SelectsAllFilteredApps()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         vm.SelectAllCommand.Execute(null);
         Assert.All(vm.FilteredApps, app => Assert.True(app.IsSelected));
     }
 
     [Fact]
     public void DeselectAll_DeselectsAllApps()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         // First select all, then deselect
         vm.SelectAllCommand.Execute(null);
         vm.DeselectAllCommand.Execute(null);
@@ -63,7 +63,7 @@ public void DeselectAll_DeselectsAllApps()
     [InlineData("Runtimes & Frameworks", 4)]
     public void FilterByCategory_ShowsOnlyMatchingCategory(string category, int expectedCount)
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         vm.SelectedCategory = category;
         Assert.Equal(expectedCount, vm.FilteredApps.Count);
         Assert.All(vm.FilteredApps, app => Assert.Equal(category, app.Category));
@@ -75,15 +75,15 @@ public void FilterByCategory_ShowsOnlyMatchingCategory(string category, int expe
     [InlineData("zzz_nonexistent", 0)]
     public void FilterByText_ShowsMatchingName(string text, int expectedCount)
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         vm.FilterText = text;
         Assert.Equal(expectedCount, vm.FilteredApps.Count);
     }
 
     [Fact]
     public void CombinedFilter_CategoryAndText_Works()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         vm.SelectedCategory = "Development";
         vm.FilterText = "Git";
         Assert.Single(vm.FilteredApps);
@@ -93,7 +93,7 @@ public void CombinedFilter_CategoryAndText_Works()
     [Fact]
     public void Categories_ContainsAllAndElevenSpecificPlusCustom()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Contains("All", vm.Categories);
         Assert.Contains("Custom", vm.Categories);
         Assert.Equal(13, vm.Categories.Count);
@@ -104,7 +104,7 @@ public void Categories_ContainsAllAndElevenSpecificPlusCustom()
     [Fact]
     public void InstallSelectedCommand_DisabledWhileBusy()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.True(vm.InstallSelectedCommand.CanExecute(null));   // idle → clickable
 
         vm.IsBusy = true;

SysManager/SysManager.Tests/ContextMenuViewModelTests.cs

@@ -14,12 +14,12 @@ namespace SysManager.Tests;
 /// </summary>
 public class ContextMenuViewModelTests
 {
-    private static ContextMenuViewModel CreateVm() => new(new ContextMenuService());
+    private static ContextMenuViewModel NewVm() => new(new ContextMenuService());
 
     [Fact]
     public void Constructor_LocationFilters_ContainsAllPlusSpecific()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Contains("All", vm.LocationFilters);
         Assert.Contains("Files", vm.LocationFilters);
         Assert.Contains("Folders", vm.LocationFilters);
@@ -31,50 +31,50 @@ public void Constructor_LocationFilters_ContainsAllPlusSpecific()
     [Fact]
     public void Constructor_SelectedLocation_DefaultsToAll()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal("All", vm.SelectedLocation);
     }
 
     [Fact]
     public void Constructor_FilterText_DefaultsEmpty()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal("", vm.FilterText);
     }
 
     [Fact]
     public void Constructor_Entries_StartsEmpty()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         // Before scan, entries should be empty
         Assert.Empty(vm.Entries);
     }
 
     [Fact]
     public void Constructor_TotalCount_DefaultsToZero()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(0, vm.TotalCount);
     }
 
     [Fact]
     public void Constructor_EnabledCount_DefaultsToZero()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(0, vm.EnabledCount);
     }
 
     [Fact]
     public void Constructor_DisabledCount_DefaultsToZero()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(0, vm.DisabledCount);
     }
 
     [Fact]
     public void Commands_NotNull()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.NotNull(vm.ScanCommand);
         Assert.NotNull(vm.ToggleEntryCommand);
         Assert.NotNull(vm.RefreshCommand);
@@ -84,7 +84,7 @@ public void Commands_NotNull()
     [Fact]
     public void Constructor_ActivePresetId_DefaultsToMenuStyle()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Contains(vm.ActivePresetId, new[] { "win10", "win11" });
     }
 }

SysManager/SysManager.Tests/DnsHostsViewModelTests.cs

@@ -18,27 +18,27 @@ namespace SysManager.Tests;
 /// </summary>
 public class DnsHostsViewModelTests
 {
-    private static DnsHostsViewModel CreateVm() =>
+    private static DnsHostsViewModel NewVm() =>
         new(new DnsService(new PowerShellRunner()), new HostsFileService());
 
     [StaFact]
     public void Constructor_PresetsListPopulated_With5Presets()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(5, vm.Presets.Count);
     }
 
     [StaFact]
     public void Constructor_HostEntries_IsNotNull()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.NotNull(vm.HostEntries);
     }
 
     [StaFact]
     public void Presets_ContainsExpectedNames()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         var names = vm.Presets.Select(p => p.Name).ToList();
         Assert.Contains("Google", names);
         Assert.Contains("Cloudflare", names);
@@ -80,7 +80,7 @@ public void HostsFileService_AddEntry_WithInvalidHostname_ThrowsArgumentExceptio
     [StaFact]
     public void RemoveEntry_RemovesFromCollection()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         var entry = new HostsEntry { IpAddress = "10.0.0.1", Hostname = "test.local" };
         vm.HostEntries.Add(entry);
 

SysManager/SysManager.Tests/EqualityConverterTests.cs

@@ -32,21 +32,21 @@ public void Convert_ComparesValueToParameter(string value, string parameter, boo
     public void Convert_NullValue_ReturnsFalse()
     {
         var result = _sut.Convert(null, typeof(bool), "balanced", CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 
     [Fact]
     public void Convert_NullParameter_ReturnsFalse()
     {
         var result = _sut.Convert("balanced", typeof(bool), null, CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 
     [Fact]
     public void Convert_BothNull_ReturnsFalse()
     {
         var result = _sut.Convert(null, typeof(bool), null, CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 
     [Theory]
@@ -77,6 +77,6 @@ public void ConvertBack_WhenNull_ReturnsDoNothing()
     public void Convert_IsCaseSensitive()
     {
         var result = _sut.Convert("Balanced", typeof(bool), "balanced", CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 }

SysManager/SysManager.Tests/FileShredderViewModelTests.cs

@@ -20,34 +20,34 @@ namespace SysManager.Tests;
 [Collection("DialogService")]
 public class FileShredderViewModelTests
 {
-    private static FileShredderViewModel CreateVm() =>
+    private static FileShredderViewModel NewVm() =>
         new(new FileShredderService());
 
     [Fact]
     public void Constructor_ItemsStartsEmpty()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Empty(vm.Items);
     }
 
     [Fact]
     public void Constructor_SelectedMethodDefaultsToStandard()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(ShredMethod.Standard, vm.SelectedMethod);
     }
 
     [Fact]
     public void Constructor_SelectedMethodValueIs3()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.Equal(3, (int)vm.SelectedMethod);
     }
 
     [Fact]
     public void RemoveItem_RemovesFromList()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         var item = new ShredItem
         {
             Path = @"C:\temp\test.txt",
@@ -65,7 +65,7 @@ public void RemoveItem_RemovesFromList()
     [Fact]
     public void RemoveItem_WithNull_DoesNotCrash()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         // Should not throw when passing null
         vm.RemoveItemCommand.Execute(null);
         Assert.Empty(vm.Items);
@@ -74,21 +74,21 @@ public void RemoveItem_WithNull_DoesNotCrash()
     [Fact]
     public void IsShredding_DefaultsFalse()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.False(vm.IsShredding);
     }
 
     [Fact]
     public void IsBusy_DefaultsFalse()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         Assert.False(vm.IsBusy);
     }
 
     [Fact]
     public void Items_CanAddMultiple()
     {
-        var vm = CreateVm();
+        var vm = NewVm();
         vm.Items.Add(new ShredItem { Path = @"C:\a.txt", Name = "a.txt", SizeBytes = 100, IsFolder = false });
         vm.Items.Add(new ShredItem { Path = @"C:\b.txt", Name = "b.txt", SizeBytes = 200, IsFolder = false });
         vm.Items.Add(new ShredItem { Path = @"C:\folder", Name = "folder", SizeBytes = 5000, IsFolder = true });
@@ -109,7 +109,7 @@ public async Task ShredAll_WhenUserDeclinesConfirm_ShredsNothing()
         DialogService.Instance = dialog;
         try
         {
-            var vm = CreateVm();
+            var vm = NewVm();
             vm.Items.Add(new ShredItem
             {
                 Path = file, Name = Path.GetFileName(file), SizeBytes = 1, IsFolder = false
@@ -140,7 +140,7 @@ public async Task ShredAll_WhenUserConfirms_ShredsSelectedFile()
         DialogService.Instance = dialog;
         try
         {
-            var vm = CreateVm();
+            var vm = NewVm();
             vm.Items.Add(new ShredItem
             {
                 Path = file, Name = Path.GetFileName(file), SizeBytes = 1, IsFolder = false
@@ -166,7 +166,7 @@ public async Task ShredAll_WithNoItems_NeverPromptsConfirm()
         DialogService.Instance = dialog;
         try
         {
-            var vm = CreateVm(); // Items empty
+            var vm = NewVm(); // Items empty
 
             await vm.ShredAllCommand.ExecuteAsync(null);
 

SysManager/SysManager.Tests/IntGreaterThanZeroConverterTests.cs

@@ -31,14 +31,14 @@ public void Convert_ReturnsExpected(int input, bool expected)
     public void Convert_NonInt_ReturnsFalse()
     {
         var result = _sut.Convert("hello", typeof(bool), null!, CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 
     [Fact]
     public void Convert_Null_ReturnsFalse()
     {
         var result = _sut.Convert(null!, typeof(bool), null!, CultureInfo.InvariantCulture);
-        Assert.Equal(false, result);
+        Assert.False((bool)result!);
     }
 
     [Fact]