Skip to content

test: uniformize VM test helper naming and boolean assertions#965

Merged
laurentiu021 merged 1 commit into
mainfrom
test/uniformize-vm-test-helpers
Jun 22, 2026
Merged

test: uniformize VM test helper naming and boolean assertions#965
laurentiu021 merged 1 commit into
mainfrom
test/uniformize-vm-test-helpers

Conversation

@laurentiu021

Copy link
Copy Markdown
Owner

Summary

First batch of the modernization+uniformity sweep (test-project uniformity). No production code touched; test: so no release.

Changes

  • CreateVm() -> NewVm() in 7 test files (BulkInstaller, ContextMenu, DnsHosts, FileShredder, Performance, Privacy, Uninstaller). The majority of the suite (10 files) already used NewVm(); these 7 were the outliers. Now uniform across all ViewModel tests.
  • Assert.Equal(false, result) -> Assert.False((bool)result!) in EqualityConverterTests and IntGreaterThanZeroConverterTests, matching the boolean-assertion style used everywhere else. (The cast is needed because IValueConverter.Convert returns object.)

Verification

  • dotnet build (tests project): 0 warnings, 0 errors (TreatWarningsAsErrors=true).
  • Pure rename + assertion-style change; no test logic or coverage changed.

@laurentiu021 laurentiu021 merged commit 90ea6fd into main Jun 22, 2026
4 checks passed
@laurentiu021 laurentiu021 deleted the test/uniformize-vm-test-helpers branch June 22, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant