feat: add table branch error codes across spec, python, and java#352
Merged
brendanclement merged 2 commits intoJun 11, 2026
Merged
Conversation
jackye1995
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Rust implementation in lance-format/lance defines TableBranchNotFound (22) and TableBranchAlreadyExists (23), but the spec registry and the Python and Java interface modules stop at 21. Clients converting errors by code (for example pylance via lance_namespace.errors.from_error_code) currently reclassify branch failures as InternalError, so deleting a missing branch surfaces as an internal error instead of a branch-not-found error.
This adds the two branch error codes everywhere the registry lives:
Testing
Python round-trip test for both codes (from_error_code returns the typed exceptions with the right code values).
Surfaced by review feedback on lance-format/lance#7219, where the new Python branch API bindings expose the gap.