Skip to content

bugfix: remove side effect from map random ordering on FindDifference… #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zipzap11 merged 2 commits into from
Oct 30, 2025
Merged

bugfix: remove side effect from map random ordering on FindDifference… #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92bb22d
bugfix: remove side effect from map random ordering on FindDifference…
Oct 23, 2025
5724cf9
bump: update changelog
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
# go-utils

<a name="v1.42.1"></a>
## [v1.42.1] - 2025-10-23
### Fixes
- remove side effect from map random ordering on FindDifferencesFromSlices


<a name="v1.42.0"></a>
## [v1.42.0] - 2025-10-22
### New Features
- identifier tanya
- identifier tanya ([#72](https://github.com/kumparan/go-utils/issues/72))


<a name="v1.41.0"></a>
Expand Down Expand Up @@ -213,9 +219,6 @@
- fix marshal issue on gorm.DeletedAt empty value ([#32](https://github.com/kumparan/go-utils/issues/32))


<a name="v.1.20.0"></a>
## [v.1.20.0] - 2022-03-11

<a name="v1.20.0"></a>
## [v1.20.0] - 2022-03-11
### New Features
Expand Down Expand Up @@ -315,11 +318,11 @@
- add money formatter for multiple currencies ([#13](https://github.com/kumparan/go-utils/issues/13))


<a name="v1.7.1"></a>
## [v1.7.1] - 2020-12-10

<a name="v1.8.0"></a>
## [v1.8.0] - 2020-12-10

<a name="v1.7.1"></a>
## [v1.7.1] - 2020-12-10
### New Features
- add formatter for indonesian money and date

Expand Down Expand Up @@ -384,7 +387,8 @@
- init go-utils


[Unreleased]: https://github.com/kumparan/go-utils/compare/v1.42.0...HEAD
[Unreleased]: https://github.com/kumparan/go-utils/compare/v1.42.1...HEAD
[v1.42.1]: https://github.com/kumparan/go-utils/compare/v1.42.0...v1.42.1
[v1.42.0]: https://github.com/kumparan/go-utils/compare/v1.41.0...v1.42.0
[v1.41.0]: https://github.com/kumparan/go-utils/compare/v1.40.2...v1.41.0
[v1.40.2]: https://github.com/kumparan/go-utils/compare/v1.40.1...v1.40.2
Expand Down Expand Up @@ -418,8 +422,7 @@
[v1.23.0]: https://github.com/kumparan/go-utils/compare/v1.22.0...v1.23.0
[v1.22.0]: https://github.com/kumparan/go-utils/compare/v1.21.0...v1.22.0
[v1.21.0]: https://github.com/kumparan/go-utils/compare/v1.20.1...v1.21.0
[v1.20.1]: https://github.com/kumparan/go-utils/compare/v.1.20.0...v1.20.1
[v.1.20.0]: https://github.com/kumparan/go-utils/compare/v1.20.0...v.1.20.0
[v1.20.1]: https://github.com/kumparan/go-utils/compare/v1.20.0...v1.20.1
[v1.20.0]: https://github.com/kumparan/go-utils/compare/v1.19.3...v1.20.0
[v1.19.3]: https://github.com/kumparan/go-utils/compare/v1.19.2...v1.19.3
[v1.19.2]: https://github.com/kumparan/go-utils/compare/v1.19.1...v1.19.2
Expand All @@ -436,9 +439,9 @@
[v1.12.0]: https://github.com/kumparan/go-utils/compare/v1.11.0...v1.12.0
[v1.11.0]: https://github.com/kumparan/go-utils/compare/v1.10.0...v1.11.0
[v1.10.0]: https://github.com/kumparan/go-utils/compare/v1.9.0...v1.10.0
[v1.9.0]: https://github.com/kumparan/go-utils/compare/v1.7.1...v1.9.0
[v1.7.1]: https://github.com/kumparan/go-utils/compare/v1.8.0...v1.7.1
[v1.8.0]: https://github.com/kumparan/go-utils/compare/v1.7.0...v1.8.0
[v1.9.0]: https://github.com/kumparan/go-utils/compare/v1.8.0...v1.9.0
[v1.8.0]: https://github.com/kumparan/go-utils/compare/v1.7.1...v1.8.0
[v1.7.1]: https://github.com/kumparan/go-utils/compare/v1.7.0...v1.7.1
[v1.7.0]: https://github.com/kumparan/go-utils/compare/v1.6.0...v1.7.0
[v1.6.0]: https://github.com/kumparan/go-utils/compare/v1.5.0...v1.6.0
[v1.5.0]: https://github.com/kumparan/go-utils/compare/v1.4.0...v1.5.0
Expand Down
7 changes: 6 additions & 1 deletion slice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,18 +165,23 @@ func FindDifferencesFromSlices[T comparable](slices ...[]T) []T {
return nil
}

var allItems []T
itemCountMap := map[T]int{}
for _, slice := range slices {
handledItem := map[T]bool{}
for _, item := range slice {
// handle duplicate item in one slice
if !handledItem[item] {
itemCountMap[item]++
allItems = append(allItems, item)
handledItem[item] = true
}
}
}
allItems = Unique(allItems)
var result []T
for item, count := range itemCountMap {
for _, item := range allItems {
count := itemCountMap[item]
if count < len(slices) {
result = append(result, item)
}
Expand Down
8 changes: 8 additions & 0 deletions slice_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@ func Test_FindDifferencesFromSlices(t *testing.T) {
},
result: nil,
},
{
slices: [][]string{
{"b", "a", "c"},
{"a", "c", "d"},
{"e", "f", "a", "b"},
},
result: []string{"b", "d", "e", "f"},
},
}

for _, tc := range testCases {
Expand Down