bugfix: remove side effect from map random ordering on FindDifference…#73
Merged
bugfix: remove side effect from map random ordering on FindDifference…#73
Conversation
Contributor
zipzap11
commented
Oct 24, 2025
zipzap11
commented
- not consistently returning result with same order
aslamhadi
reviewed
Oct 24, 2025
slice.go
Outdated
| return nil | ||
| } | ||
|
|
||
| var allItem []T |
zhenqianz
reviewed
Oct 24, 2025
slice.go
Outdated
| allItem = Unique(allItem) | ||
| var result []T | ||
| for item, count := range itemCountMap { | ||
| for _, item := range allItem { |
Collaborator
There was a problem hiding this comment.
tambahin unit testnya king
zipzap11
force-pushed
the
bugfix/remove-side-effect
branch
from
4859764 to
5724cf9
Compare
atjhoendz
approved these changes
Oct 27, 2025
naluthfi
approved these changes
Oct 27, 2025
aslamhadi
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.