Skip to content

Fix remaining race conditions in rekt tests #8902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Mar 6, 2026
Merged

Fix remaining race conditions in rekt tests #8902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions test/rekt/features/apiserversource/data_plane.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,8 @@ func SendsEventsWithObjectReferencePayload() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down Expand Up @@ -447,7 +448,8 @@ func SendsEventsWithResourceEventPayload() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down Expand Up @@ -490,7 +492,8 @@ func SendsEventsForAllResources() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down Expand Up @@ -546,7 +549,8 @@ func SendsEventsForAllResourcesWithNamespaceSelector() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

pod1 := feature.MakeRandomK8sName("example-pod-1")
pod2 := feature.MakeRandomK8sName("example-pod-2")
Expand Down Expand Up @@ -620,7 +624,8 @@ func SendsEventsForAllResourcesWithEmptyNamespaceSelector() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

pingSource1 := feature.MakeRandomK8sName("ping-source-1")
pingSource2 := feature.MakeRandomK8sName("ping-source-2")
Expand Down Expand Up @@ -675,7 +680,8 @@ func SendsEventsForLabelMatchingResources() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down Expand Up @@ -769,7 +775,8 @@ func SendEventsForLabelExpressionMatchingResources() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down Expand Up @@ -1043,7 +1050,8 @@ func EventsAreFilteredOut() *feature.Feature {
}

f.Setup("install ApiServerSource", apiserversource.Install(source, cfg...))
f.Setup("ApiServerSource goes ready", apiserversource.IsReady(source))

f.Requirement("ApiServerSource goes ready", apiserversource.IsReady(source))

examplePodName := feature.MakeRandomK8sName("example")

Expand Down
3 changes: 2 additions & 1 deletion test/rekt/features/broker/control_plane.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ func ControlPlaneBroker(brokerName string, brokerOpts ...manifest.CfgFn) *featur
brokerOpts = append(brokerOpts, broker.WithEnvConfig()...)
brokerOpts = append(brokerOpts, delivery.WithDeadLetterSink(service.AsKReference(sink), ""))
f.Setup("update broker", broker.Install(bName, brokerOpts...))
f.Setup("broker goes ready", broker.IsReady(bName))

f.Requirement("broker goes ready", broker.IsReady(bName))

f.Stable("Conformance").
Should("Broker objects SHOULD include a Ready condition in their status",
Expand Down
3 changes: 1 addition & 2 deletions test/rekt/features/broker/source_to_sink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ func SourceToSink(brokerName string) *feature.Feature {
// Install the trigger
f.Setup("install trigger", trigger.Install(via, cfg...))

f.Setup("trigger goes ready", trigger.IsReady(via))

f.Requirement("trigger goes ready", trigger.IsReady(via))
f.Requirement("install source", eventshub.Install(source,
eventshub.StartSenderToResource(broker.GVR(), brokerName),
eventshub.InputEvent(event),
Expand Down
5 changes: 3 additions & 2 deletions test/rekt/features/eventtransform/eventtransform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ func JsonataDirectTLS() *feature.Feature {
)))
f.Requirement("event transform is addressable", eventtransform.IsAddressable(transformName))
f.Requirement("event transform is ready", eventtransform.IsReady(transformName))
f.Setup("event transform has HTTPS address", eventtransform.ValidateAddress(transformName, addressable.AssertHTTPSAddress))
f.Requirement("event transform has HTTPS address", eventtransform.ValidateAddress(transformName, addressable.AssertHTTPSAddress))

f.Requirement("install source", eventshub.Install(source,
eventshub.InputEvent(event),
Expand Down Expand Up @@ -403,7 +403,8 @@ func JsonataSinkTLS() *feature.Feature {
f.Setup("install sink", eventshub.Install(sink,
eventshub.IssuerRef(eventingtlstesting.IssuerKind, eventingtlstesting.IssuerName),
eventshub.StartReceiverTLS))
f.Setup("event transform has HTTPS address", eventtransform.ValidateAddress(transformName, addressable.AssertHTTPSAddress))

f.Requirement("event transform has HTTPS address", eventtransform.ValidateAddress(transformName, addressable.AssertHTTPSAddress))

f.Requirement("install source", eventshub.Install(source,
eventshub.InputEvent(event),
Expand Down
Loading