Fix remaining race conditions in rekt tests#8902
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Mar 6, 2026
Merged
Fix remaining race conditions in rekt tests#8902knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
Move additional readiness checks from f.Setup() to f.Requirement() that were missed in the previous commit.
knative-prow
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8902 +/- ##
==========================================
- Coverage 50.67% 50.65% -0.03%
==========================================
Files 409 409
Lines 21694 21694
==========================================
- Hits 10994 10989 -5
- Misses 9848 9853 +5
Partials 852 852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more test fixes after #8900