Merged
Conversation
ondrajodas
commented
Oct 3, 2025
| return $config; | ||
| } | ||
|
|
||
| public function testAppRunDailyWalk(): void |
Contributor
Author
There was a problem hiding this comment.
GA4 už nejsou... takže jejich testy nebudou fungovat - pryč s tím
ondrajodas
force-pushed
the
AJDA-1176-ondra
branch
from
3f01fc9 to
0493ef8
Compare
ErikZigo
reviewed
Oct 3, 2025
| } | ||
|
|
||
| public function paginate(array $query, array $report, CsvFile $csvFile): void | ||
| public function paginate(array $query, array $report, CsvFile $csvFile): int |
Contributor
Author
There was a problem hiding this comment.
no jo, máš ho tam... dal jsem ho jen k tomu PropertiesPaginator, protože ten Profiles se jednoho krásnýho dne smaže - google už nepodporuje tyhle starý reporty a už se na ně nedoboucháš
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://keboola.atlassian.net/browse/AJDA-1176
buď to fixneme takto - až ve chvíli kdy jsou nějaká data tak vytvoříme manifest a nebo druhá možnost že ten datový soubor vytvoříme hned tady https://github.com/keboola/google-analytics-extractor/blob/master/src/Extractor/Output.php#L164 a taky by se to tím vyřešilo