Skip to content

Fix flaking TestImpersonation #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcp-ci-bot merged 1 commit into from
Mar 20, 2026
Merged

Fix flaking TestImpersonation #3932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions test/e2e/authorizer/impersonate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

authenticationv1 "k8s.io/api/authentication/v1"
Expand Down Expand Up @@ -62,13 +63,13 @@ func TestImpersonation(t *testing.T) {

t.Logf("User-1 should not be able to edit workspace status")
var ws *tenancyv1alpha1.Workspace
require.Eventually(t, func() bool {
require.EventuallyWithT(t, func(c *assert.CollectT) {
var err error
ws, err = user1Client.TenancyV1alpha1().Workspaces().Cluster(org).Get(ctx, wsObj.Name, metav1.GetOptions{})
require.NoError(t, err)
require.NoError(c, err)
ws.Status.Phase = "Scheduling"
_, err = user1Client.TenancyV1alpha1().Workspaces().Cluster(org).UpdateStatus(ctx, ws, metav1.UpdateOptions{})
return apierrors.IsForbidden(err)
require.True(c, apierrors.IsForbidden(err))
}, wait.ForeverTestTimeout, time.Millisecond*100, "user-1 should not be able to edit its own workspace status")

user1Cfg.Impersonate = rest.ImpersonationConfig{
Expand All @@ -79,10 +80,10 @@ func TestImpersonation(t *testing.T) {
require.NoError(t, err)

t.Logf("User-1 should NOT be able to edit workspace status with system:masters impersonation")
require.Eventually(t, func() bool {
require.EventuallyWithT(t, func(c *assert.CollectT) {
ws.Status.Phase = "Scheduling"
_, err = user1Client.TenancyV1alpha1().Workspaces().Cluster(org).UpdateStatus(ctx, ws, metav1.UpdateOptions{})
return apierrors.IsForbidden(err)
require.True(c, apierrors.IsForbidden(err))
}, wait.ForeverTestTimeout, time.Millisecond*100, "user-1 should NOT be able to edit its own workspace status with impersonation")
}

Expand Down