Fix flaking TestImpersonation#3932
Merged
kcp-ci-bot merged 1 commit intokcp-dev:mainfrom Mar 20, 2026
Merged
Conversation
TestImpersonation used require.NoError within require.Eventually, meaning if the user is not immediately able to access the workspace the test fails. Signed-off-by: Nelo-T. Wallus <red.brush9525@fastmail.com> Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
ntnn
added
the
tide/merge-method-squash
kcp-ci-bot
added
release-note-none
Contributor
|
/retest |
Member
Author
|
/retest |
Member
Author
|
/retest CI infra |
Member
Author
|
/retest flake |
Contributor
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: dfcdafd14eb52d45465f75ed1342399d1a7f5f93 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestImpersonation used require.NoError within require.Eventually, meaning if the user is not immediately able to access the workspace the test fails.
What Type of PR Is This?
/kind flake
Related Issue(s)
Fixes #
Release Notes