[release-0.7] Use the GroupVersion.Version instead of the resources' preferred version#177
Merged
kcp-ci-bot merged 1 commit intoJun 30, 2026
Conversation
APIResource.Version may be empty: https://github.com/kubernetes/apimachinery/blob/6fa8dff7b19f13e310ef489972c8f394a9c185ad/pkg/apis/meta/v1/types.go#L1235-L1237 Additionally it reports the resources' preferred version, not the version it was listed for per APIResourceList.GroupVersion: https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go I believe this is irrelevant in most cases however we hit this when using api-syncagent against resources provided by an aggregated API server, which does not fill the .Version on the resource. Signed-off-by: Nelo-T. Wallus <n.wallus@sap.com>
kcp-ci-bot
added
release-note-none
Member
|
/lgtm |
kcp-ci-bot
added
size/M
Contributor
Author
|
LGTM label has been added. DetailsGit tree hash: 580c717312533808e2b62d3449f2d79d94cb6779 |
Member
|
/kind bug |
kcp-ci-bot
added
kind/bug
Member
|
/lgtm |
Contributor
|
/approve |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #176
/assign ntnn